Bug 235599 - [macOS][WP] Allow mach extension to service
Summary: [macOS][WP] Allow mach extension to service
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-25 10:42 PST by Per Arne Vollan
Modified: 2022-01-25 17:02 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.40 KB, patch)
2022-01-25 10:53 PST, Per Arne Vollan
darin: review+
Details | Formatted Diff | Diff
Patch (1.41 KB, patch)
2022-01-25 16:04 PST, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2022-01-25 10:42:37 PST
Allow mach extension to a service in the WebContent process on macOS.
Comment 1 Per Arne Vollan 2022-01-25 10:42:57 PST
<rdar://87850345>
Comment 2 Per Arne Vollan 2022-01-25 10:53:20 PST
Created attachment 449942 [details]
Patch
Comment 3 Darin Adler 2022-01-25 15:08:12 PST
Comment on attachment 449942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449942&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1111
> +;; rdar://87850345

Generally in WebKit we try to put comments that would work for people even outside Apple, so a Radar link is not the right pattern. It’s possible, though, that the sandbox profile is an exception to this.
Comment 4 Per Arne Vollan 2022-01-25 16:04:43 PST
Created attachment 449978 [details]
Patch
Comment 5 Per Arne Vollan 2022-01-25 16:05:49 PST
(In reply to Darin Adler from comment #3)
> Comment on attachment 449942 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449942&action=review
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1111
> > +;; rdar://87850345
> 
> Generally in WebKit we try to put comments that would work for people even
> outside Apple, so a Radar link is not the right pattern. It’s possible,
> though, that the sandbox profile is an exception to this.

That is a good point. I have added a short comment in addition to the Radar link.

Thanks for reviewing!
Comment 6 EWS 2022-01-25 17:02:35 PST
Committed r288591 (246413@main): <https://commits.webkit.org/246413@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449978 [details].