Bug 235559 – REGRESSION(r281419): iCloud.com Notes web app fonts render incorrectly

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

REGRESSION(r281419): iCloud.com Notes web app fonts render incorrectly

[Myles C. Maxfield]

<rdar://problem/87268956>

[Myles C. Maxfield]

Created attachment 449899 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[Darin Adler]

Comment on attachment 449899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449899&action=review

> Source/WebCore/platform/graphics/WidthIterator.cpp:608
> +        // "Control characters (Unicode category Cc)âother than NULL (U+0000), tabs (U+0009), line feeds (U+000A), carriage returns (U+000D) and sequences that form a segment breakâmust be rendered as a visible glyph"

Seems like this "counts your chickens before they are hatched" since it assumes your pull request will be approved. If I was you I would be tempted to write a brief comment that more literally explains the current status of this rather than assuming the change to the spec will go through.

> Source/WebCore/platform/graphics/WidthIterator.cpp:610
> +            && u_charType(characterResponsibleForThisGlyph) == U_CONTROL_CHAR) {

Does this really reject tabs, line feeds, carriage returns, and sequences that form a segment break? The comment above lists all those special cases, and the code here doesn’t cover them. It seems like the comment might need to explain why the code below doesn’t match it?

[Myles C. Maxfield]

Comment on attachment 449899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449899&action=review

>> Source/WebCore/platform/graphics/WidthIterator.cpp:610
>> +            && u_charType(characterResponsibleForThisGlyph) == U_CONTROL_CHAR) {
> 
> Does this really reject tabs, line feeds, carriage returns, and sequences that form a segment break? The comment above lists all those special cases, and the code here doesn’t cover them. It seems like the comment might need to explain why the code below doesn’t match it?

Those are handled in the stanza right above this one.

[Myles C. Maxfield]

Committed r288564 (246392@trunk): <https://commits.webkit.org/246392@trunk>