RESOLVED FIXED 235559
REGRESSION(r281419): iCloud.com Notes web app fonts render incorrectly
https://bugs.webkit.org/show_bug.cgi?id=235559
Summary REGRESSION(r281419): iCloud.com Notes web app fonts render incorrectly
Myles C. Maxfield
Reported 2022-01-24 22:31:01 PST
REGRESSION(r281419): iCloud.com Notes web app fonts render incorrectly
Attachments
Patch (5.06 KB, patch)
2022-01-24 22:36 PST, Myles C. Maxfield
darin: review+
Myles C. Maxfield
Comment 1 2022-01-24 22:35:27 PST
Myles C. Maxfield
Comment 2 2022-01-24 22:36:00 PST
EWS Watchlist
Comment 3 2022-01-24 22:38:23 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Darin Adler
Comment 4 2022-01-24 22:58:48 PST
Comment on attachment 449899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449899&action=review > Source/WebCore/platform/graphics/WidthIterator.cpp:608 > + // "Control characters (Unicode category Cc)âother than NULL (U+0000), tabs (U+0009), line feeds (U+000A), carriage returns (U+000D) and sequences that form a segment breakâmust be rendered as a visible glyph" Seems like this "counts your chickens before they are hatched" since it assumes your pull request will be approved. If I was you I would be tempted to write a brief comment that more literally explains the current status of this rather than assuming the change to the spec will go through. > Source/WebCore/platform/graphics/WidthIterator.cpp:610 > + && u_charType(characterResponsibleForThisGlyph) == U_CONTROL_CHAR) { Does this really reject tabs, line feeds, carriage returns, and sequences that form a segment break? The comment above lists all those special cases, and the code here doesn’t cover them. It seems like the comment might need to explain why the code below doesn’t match it?
Myles C. Maxfield
Comment 5 2022-01-24 23:14:32 PST
Comment on attachment 449899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449899&action=review >> Source/WebCore/platform/graphics/WidthIterator.cpp:610 >> + && u_charType(characterResponsibleForThisGlyph) == U_CONTROL_CHAR) { > > Does this really reject tabs, line feeds, carriage returns, and sequences that form a segment break? The comment above lists all those special cases, and the code here doesn’t cover them. It seems like the comment might need to explain why the code below doesn’t match it? Those are handled in the stanza right above this one.
Myles C. Maxfield
Comment 6 2022-01-25 10:50:16 PST
Note You need to log in before you can comment on or make changes to this bug.