Bug 235550 - Support workspace builds in build-webkit
Summary: Support workspace builds in build-webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-24 17:10 PST by Elliott Williams
Modified: 2022-01-26 11:24 PST (History)
3 users (show)

See Also:

Attachments
Patch (9.20 KB, patch)
2022-01-24 17:17 PST, Elliott Williams 		no flags Details | Formatted Diff | Diff
Patch (9.43 KB, patch)
2022-01-24 18:09 PST, Elliott Williams 		no flags Details | Formatted Diff | Diff
Patch (10.27 KB, patch)
2022-01-25 10:57 PST, Elliott Williams 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2022-01-24 17:10:51 PST 
Support workspace builds in build-webkit
Comment 1 Elliott Williams 2022-01-24 17:17:40 PST 
Created attachment 449884 [details]
Patch
Comment 2 Elliott Williams 2022-01-24 18:09:39 PST 
Created attachment 449886 [details]
Patch
Comment 3 Alexey Proskuryakov 2022-01-25 10:00:06 PST 
Comment on attachment 449886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449886&action=review

r=me. I don't see how the Windows build failure can be caused by this.

> Tools/Scripts/build-webkit:126
> +  --[no-]use-workspace              Use WebKit.xcworkspace and XCBuild (iOS and Mac only)

AFAICT this affects watchOS and tvOS too.
Comment 4 Elliott Williams 2022-01-25 10:57:02 PST 
Created attachment 449943 [details]
Patch
Comment 5 Elliott Williams 2022-01-25 10:58:09 PST 
(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 449886 [details]
> Patch
> 
> > Tools/Scripts/build-webkit:126
> > +  --[no-]use-workspace              Use WebKit.xcworkspace and XCBuild (iOS and Mac only)
> 
> AFAICT this affects watchOS and tvOS too.

Good catch, I've changed this and a couple other Xcode-specific flags to say "Apple platforms only".
Comment 6 Elliott Williams 2022-01-26 10:30:51 PST 
(In reply to Elliott Williams from comment #5)
> I've changed this and a couple other Xcode-specific flags to say
> "Apple platforms only".

This patch is ready to go, and shouldn't need additional review since it's a usage-text-only change. The windows build failure has sorted itself out, and the jsc-armv7 test failure appears to be a flake.
Comment 7 EWS 2022-01-26 11:23:17 PST 
Committed r288632 (246447@main): <https://commits.webkit.org/246447@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449943 [details].
Comment 8 Radar WebKit Bug Importer 2022-01-26 11:24:19 PST 
<rdar://problem/88086388>