Bug 235539 - Web Inspector: Network: give the Ignore Caches button a label so it's more visible and immediately understandable
Summary: Web Inspector: Network: give the Ignore Caches button a label so it's more vi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-24 13:44 PST by Devin Rousso
Modified: 2022-01-24 19:22 PST (History)
6 users (show)

See Also:


Attachments
[fast-cq] Patch (6.33 KB, patch)
2022-01-24 13:48 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
[Image] after Patch is applied (72.94 KB, image/png)
2022-01-24 14:32 PST, Devin Rousso
no flags Details
Patch (6.81 KB, patch)
2022-01-24 14:43 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
[fast-cq] Patch (6.78 KB, patch)
2022-01-24 14:53 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
[fast-cq] Patch (8.30 KB, patch)
2022-01-24 16:50 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2022-01-24 13:44:58 PST
.
Comment 1 Devin Rousso 2022-01-24 13:48:32 PST
Created attachment 449853 [details]
[fast-cq] Patch
Comment 2 Patrick Angle 2022-01-24 14:01:40 PST
<rdar://87792377>
Comment 3 Joseph Pecoraro 2022-01-24 14:02:29 PST
Sounds like a good idea! Screenshot?
Comment 4 Devin Rousso 2022-01-24 14:32:49 PST
Created attachment 449858 [details]
[Image] after Patch is applied
Comment 5 Devin Rousso 2022-01-24 14:43:04 PST
Created attachment 449860 [details]
Patch

fix issue where the `WI.DividerNavigationItem` would get hidden before `this._disableResourceCacheNavigationItem`
Comment 6 Devin Rousso 2022-01-24 14:53:19 PST
Created attachment 449863 [details]
[fast-cq] Patch

rebase
Comment 7 Joseph Pecoraro 2022-01-24 15:16:43 PST
Comment on attachment 449863 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449863&action=review

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:-146
> -            this._disableResourceCacheNavigationItem = new WI.ActivateButtonNavigationItem("disable-resource-cache", toolTipForDisableResourceCache, activatedToolTipForDisableResourceCache, "Images/IgnoreCaches.svg", 16, 16);

Seems like we can delete `IgnoreCaches.svg` now?
Comment 8 Devin Rousso 2022-01-24 16:50:10 PST
Created attachment 449882 [details]
[fast-cq] Patch
Comment 9 Patrick Angle 2022-01-24 18:45:38 PST
Comment on attachment 449882 [details]
[fast-cq] Patch

r=me

I think you need to rebase again before landing, though. The review tool is complaining that it can't apply the patch any more.
Comment 10 EWS 2022-01-24 19:22:12 PST
Committed r288533 (246367@main): <https://commits.webkit.org/246367@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449882 [details].