Bug 235532 - Soft link ARKit in a separate ARKitSoftLink file
Summary: Soft link ARKit in a separate ARKitSoftLink file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-24 12:05 PST by Ada Chan
Modified: 2022-01-24 15:04 PST (History)
3 users (show)

See Also:


Attachments
Patch (11.16 KB, patch)
2022-01-24 12:06 PST, Ada Chan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2022-01-24 12:05:24 PST
Soft link ARKit in a separate ARKitSoftLink file
Comment 1 Ada Chan 2022-01-24 12:06:51 PST
Created attachment 449840 [details]
Patch
Comment 2 Tim Horton 2022-01-24 12:12:05 PST
Comment on attachment 449840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449840&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:12605
> +				7BDDA3192747C0400038659E /* (null) in Headers */,

Weird
Comment 3 Ada Chan 2022-01-24 13:02:17 PST
(In reply to Tim Horton from comment #2)
> Comment on attachment 449840 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449840&action=review
> 
> > Source/WebKit/WebKit.xcodeproj/project.pbxproj:12605
> > +				7BDDA3192747C0400038659E /* (null) in Headers */,
> 
> Weird

I think Xcode re-arranged stuff for me but that (null) thing is weird. I think that was added initially in https://bugs.webkit.org/show_bug.cgi?id=231674. Does that look like an intentional change?
Comment 4 Tim Horton 2022-01-24 13:04:03 PST
Yeah, the rearranging is fine, the (null) is weird. Does not seem intentional but certainly not your doing :)
Comment 5 EWS 2022-01-24 15:03:58 PST
Committed r288475 (246358@main): <https://commits.webkit.org/246358@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449840 [details].
Comment 6 Radar WebKit Bug Importer 2022-01-24 15:04:18 PST
<rdar://problem/87992400>