Bug 23553 - Upstream changes from jcampan to fix chromium bugs 6692 and 6694
Summary: Upstream changes from jcampan to fix chromium bugs 6692 and 6694
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-26 14:51 PST by Darin Fisher (:fishd, Google)
Modified: 2009-01-26 15:07 PST (History)
0 users

See Also:


Attachments
v1 patch (8.56 KB, patch)
2009-01-26 14:52 PST, Darin Fisher (:fishd, Google)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-01-26 14:51:57 PST
Upstream changes from jcampan to fix chromium bugs 6692 and 6694

Here's the code review details:
http://codereview.chromium.org/18466

And the repository revision:
http://src.chromium.org/viewvc/chrome?view=rev&revision=8482
Comment 1 Darin Fisher (:fishd, Google) 2009-01-26 14:52:51 PST
Created attachment 27049 [details]
v1 patch
Comment 2 Eric Seidel (no email) 2009-01-26 15:02:40 PST
Comment on attachment 27049 [details]
v1 patch

This looks fine.  I would have named things differently, but making you make renaming changes just adds needless trouble for the next merge.  We need to get off this silly merge branch.
Comment 3 Darin Fisher (:fishd, Google) 2009-01-26 15:07:05 PST
http://trac.webkit.org/changeset/40269

I cleaned up some of the "bool value" usage in the header file and fixed a few mistypes in the comments.