Bug 235493 – [GStreamer] C++20 warnings

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Philippe Normand]

/app/webkit/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:456:26: warning: ISO C++20 considers use of overloaded operator '!=' (with operand types 'GstIteratorAdaptor<_GstPad>::iterator' and 'GstIteratorAdaptor<_GstPad>::iterator') to be ambiguous despite there being a unique best viable function with non-reversed arguments [-Wambiguous-reversed-operator]
        for (GstPad* pad : GstIteratorAdaptor<GstPad>(GUniquePtr<GstIterator>(gst_element_iterate_src_pads(m_demux.get())))) {
                         ^
/app/webkit/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:392:14: note: candidate function with non-reversed arguments
        bool operator!=(const iterator& other) { return !(*this == other); }
             ^
/app/webkit/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:388:14: note: ambiguous candidate function with reversed arguments
        bool operator==(const iterator& other)
             ^
/app/webkit/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:471:26: warning: ISO C++20 considers use of overloaded operator '!=' (with operand types 'GstIteratorAdaptor<_GstPad>::iterator' and 'GstIteratorAdaptor<_GstPad>::iterator') to be ambiguous despite there being a unique best viable function with non-reversed arguments [-Wambiguous-reversed-operator]
        for (GstPad* pad : GstIteratorAdaptor<GstPad>(GUniquePtr<GstIterator>(gst_element_iterate_src_pads(m_demux.get())))) {
                         ^
/app/webkit/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:392:14: note: candidate function with non-reversed arguments
        bool operator!=(const iterator& other) { return !(*this == other); }
             ^
/app/webkit/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h:388:14: note: ambiguous candidate function with reversed arguments
        bool operator==(const iterator& other)
             ^
2 warnings generated.

[Philippe Normand]

Created attachment 449749 [details]
Patch

[Philippe Normand]

*** Bug 235075 has been marked as a duplicate of this bug. ***

[EWS]

Committed r288422 (246313@main): <https://commits.webkit.org/246313@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449749 [details].

[Radar WebKit Bug Importer]

<rdar://problem/87944376>