Bug 235481 - AX: Remove duplication in AXObjectCache::updateIsolatedTree implementations
Summary: AX: Remove duplication in AXObjectCache::updateIsolatedTree implementations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-22 09:01 PST by Tyler Wilcock
Modified: 2022-01-23 08:51 PST (History)
10 users (show)

See Also:

Attachments
Patch (5.32 KB, patch)
2022-01-22 09:08 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-01-22 09:01:28 PST 
The singular-object versions (AXObjectCache::updateIsolatedTree(AXCoreObject&, AXNotification)) and multiple-object version (AXObjectCache::updateIsolatedTree(const Vector<std::pair<RefPtr<AXCoreObject>, AXNotification>>&)) duplicate a lot of code, and make it possible to forget to add new notification handling in one place or the other.
Comment 1 Radar WebKit Bug Importer 2022-01-22 09:01:37 PST 
<rdar://problem/87926354>
Comment 2 Tyler Wilcock 2022-01-22 09:08:11 PST 
Created attachment 449733 [details]
Patch
Comment 3 EWS 2022-01-23 08:51:30 PST 
Committed r288419 (246310@main): <https://commits.webkit.org/246310@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449733 [details].