Bug 235472 - [GTK][a11y] Emit children-changed:remove signal even for ignored objects with ATSPI
Summary: [GTK][a11y] Emit children-changed:remove signal even for ignored objects with...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: ATSPI
  Show dependency tree / graph
 
Reported: 2022-01-22 01:37 PST by Carlos Garcia Campos
Modified: 2022-01-24 08:19 PST (History)
11 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2022-01-22 01:40 PST, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2022-01-22 01:37:14 PST 
We are returning early in case the object is ignored, but that could change, so if an object is not initially ignored and is registered we still need to emit children-changed:remove signal when destroyed to ensure the atspi cache is updated.
Comment 1 Carlos Garcia Campos 2022-01-22 01:40:46 PST 
Created attachment 449725 [details]
Patch
Comment 2 Carlos Garcia Campos 2022-01-24 08:19:40 PST 
Committed r288445 (?): <https://commits.webkit.org/r288445>