Bug 235465 - MediaPlayerPrivateRemote::play() and MediaPlayerPrivateRemote::pause() modify m_cachedState.paused
Summary: MediaPlayerPrivateRemote::play() and MediaPlayerPrivateRemote::pause() modify...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-21 18:42 PST by Peng Liu
Modified: 2022-01-28 18:43 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2022-01-21 18:42:38 PST
The following change is desired, but it will lead to a test timeout. (media/track/track-cues-pause-on-exit.html)

diff --git a/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp b/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
index 9a6429437842f43db6da1c25011ed4a544cbf361..cd1c9eaa70f47ecb7cf09b69c8c0bbdd00f29f43 100644
--- a/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
+++ b/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp
@@ -227,13 +227,11 @@ void MediaPlayerPrivateRemote::prepareToPlay()
 
 void MediaPlayerPrivateRemote::play()
 {
-    m_cachedState.paused = false;
     connection().send(Messages::RemoteMediaPlayerProxy::Play(), m_id);
 }
 
 void MediaPlayerPrivateRemote::pause()
 {
-    m_cachedState.paused = true;
     auto now = MonotonicTime::now();
     m_cachedMediaTime += MediaTime::createWithDouble(m_rate * (now - m_cachedMediaTimeQueryTime).value());
     m_cachedMediaTimeQueryTime = now;
Comment 1 Radar WebKit Bug Importer 2022-01-28 18:43:16 PST
<rdar://problem/88214629>