RESOLVED FIXED 235455
CSSImportRule.layerName not working when building with CMake 
https://bugs.webkit.org/show_bug.cgi?id=235455
Summary CSSImportRule.layerName not working when building with CMake
Oriol Brufau
Reported 2022-01-21 14:29:58 PST
Bug 231340 added support for CSSImportRule.layerName (https://drafts.csswg.org/css-cascade-5/#extensions-to-cssimportrule-interface) However, it doesn't exist when running WebKitGTK minibrowser, e.g. Tools/Scripts/run-minibrowser --gtk 'http://wpt.live/css/css-cascade/layer-rules-cssom.html' fails some tests. This also affects wpt.fyi, lowering WebKitGTK's score for interop-2022-cascade: https://wpt.fyi/results/css/css-cascade/layer-rules-cssom.html?label=master&label=experimental&product=webkitgtk&aligned&q=label%3Ainterop-2022-cascade I guess it's because WebKitGTK uses CMake, and CSSImportRule+Layer.idl was not included in CMakeLists.txt
Attachments
Patch (1.43 KB, patch)
2022-01-21 14:39 PST, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
Patch (3.19 KB, patch)
2022-01-21 16:31 PST, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
Patch (5.82 KB, patch)
2022-01-21 17:43 PST, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Oriol Brufau
Comment 1 2022-01-21 14:39:45 PST
Created attachment 449696 [details] Patch
Oriol Brufau
Comment 2 2022-01-21 16:31:17 PST
Created attachment 449709 [details] Patch
Oriol Brufau
Comment 3 2022-01-21 17:43:29 PST
Created attachment 449714 [details] Patch
Oriol Brufau
Comment 4 2022-01-21 17:46:55 PST
Didn't notice that css/css-cascade/idlharness.html is also passing now.
EWS
Comment 5 2022-01-22 09:27:42 PST
Committed r288404 (246295@main): <https://commits.webkit.org/246295@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449714 [details].
Radar WebKit Bug Importer
Comment 6 2022-01-22 09:28:16 PST
<rdar://problem/87926717>
Note You need to log in before you can comment on or make changes to this bug.