Bug 235454 – Web Inspector: [Flexbox] Add instrumentation/protocol bits for flex layout containers

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Patrick Angle]

<rdar://87893199>

[Patrick Angle]

Created attachment 449695 [details]
Patch v1.0

[EWS Watchlist]

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.

[Devin Rousso]

Comment on attachment 449695 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=449695&action=review

r=me, neat :)

I'm guessing the UI and other things will be coming later?

> Source/WebCore/inspector/agents/InspectorCSSAgent.cpp:945
> +    if (is<RenderFlexibleBox>(renderer))
> +        return Protocol::CSS::LayoutContextType::Flex;

NIT: I'd put this before `if (is<RenderGrid>(renderer))` so that it is alphabetical and matches the order in the protocol :P

> Source/WebCore/rendering/RenderFlexibleBox.cpp:76
>      setChildrenInline(false); // All of our children must be block-level.
> +    InspectorInstrumentation::nodeLayoutContextChanged(element, this);

Style: I'd add a newline

> Source/WebCore/rendering/RenderFlexibleBox.cpp:83
>      setChildrenInline(false); // All of our children must be block-level.
> +    InspectorInstrumentation::nodeLayoutContextChanged(document, this);

ditto (:75)

[Patrick Angle]

Created attachment 449708 [details]
Patch v1.1 - Address review nits

[Patrick Angle]

Created attachment 449820 [details]
Patch v1.2 - Resolve debug asserts

[EWS]

Committed r288492 (246364@main): <https://commits.webkit.org/246364@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449820 [details].