Bug 235423 – [libpas] Ensure pas_allocation_callback and pas_deallocation_callback are initialized as NULL

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Ensure pas_allocation_callback and pas_deallocation_callback are initialized as NULL

[Yusuke Suzuki]

Created attachment 449618 [details]
Patch

[Yusuke Suzuki]

Created attachment 449619 [details]
Patch

[Mark Lam]

Comment on attachment 449619 [details]
Patch

r=me

[EWS]

Committed r288339 (246245@main): <https://commits.webkit.org/246245@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449619 [details].

[Radar WebKit Bug Importer]

<rdar://problem/87859879>

[Filip Pizlo]

Comment on attachment 449619 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449619&action=review

> Source/bmalloc/libpas/src/libpas/pas_allocation_callbacks.c:33
> +pas_allocation_callback_t pas_allocation_callback = NULL;
> +pas_deallocation_callback_t pas_deallocation_callback = NULL;

The "_t" suffix isn't used by any types in libpas other than this.  I think that the way that I would normally do this is call the type "pas_allocation_callback" and call the variable "pas_allocation_callback_instance".  Saying "pas_allocation_callback_type" could be cool too.

[Yusuke Suzuki]

Committed r288381 (246278@trunk): <https://commits.webkit.org/246278@trunk>

[Yusuke Suzuki]

(In reply to Filip Pizlo from comment #6)
> Comment on attachment 449619 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449619&action=review
> 
> > Source/bmalloc/libpas/src/libpas/pas_allocation_callbacks.c:33
> > +pas_allocation_callback_t pas_allocation_callback = NULL;
> > +pas_deallocation_callback_t pas_deallocation_callback = NULL;
> 
> The "_t" suffix isn't used by any types in libpas other than this.  I think
> that the way that I would normally do this is call the type
> "pas_allocation_callback" and call the variable
> "pas_allocation_callback_instance".  Saying "pas_allocation_callback_type"
> could be cool too.

Changed the typenames.