RESOLVED FIXED 235403
[LFC][IFC] LineBuilder::layoutInlineContent should take PreviousLine 
https://bugs.webkit.org/show_bug.cgi?id=235403
Summary [LFC][IFC] LineBuilder::layoutInlineContent should take PreviousLine
zalan
Reported 2022-01-20 08:19:42 PST
we need to know about the previous line's state
Attachments
Patch (14.21 KB, patch)
2022-01-20 08:24 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (14.35 KB, patch)
2022-01-20 11:17 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-01-20 08:24:24 PST
Created attachment 449576 [details] Patch
Antti Koivisto
Comment 2 2022-01-20 08:38:17 PST
Comment on attachment 449576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449576&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:308 > +LineBuilder::LineContent LineBuilder::layoutInlineContent(const InlineItemRange& needsLayoutRange, const InlineRect& lineLogicalRect, std::optional<PreviousLine> previousLine) maybe the previousLine could be a const&? It is smallish but not tiny.
zalan
Comment 3 2022-01-20 11:17:13 PST
Created attachment 449596 [details] Patch
EWS
Comment 4 2022-01-20 13:19:30 PST
Committed r288317 (246233@main): <https://commits.webkit.org/246233@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449596 [details].
Radar WebKit Bug Importer
Comment 5 2022-01-20 13:20:20 PST
<rdar://problem/87846330>
Note You need to log in before you can comment on or make changes to this bug.