WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
23539
Form control specific methods could be moved away from Node/Element
https://bugs.webkit.org/show_bug.cgi?id=23539
Summary
Form control specific methods could be moved away from Node/Element
Nikolas Zimmermann
Reported
2009-01-25 17:49:19 PST
Some virtual methods living in Node/Element are related to form control elements only. isAutofilled / isTextControl / etc... (nine methods in total) As we now have some abstract base classes for form control elements (FormControlElement/InputElement/etc) we could add pure-virtual methods there, instead of jamming Node/Element. Proof-on-concept patch following.
Attachments
Initial patch
(30.31 KB, patch)
2009-01-25 17:53 PST
,
Nikolas Zimmermann
hyatt
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1
2009-01-25 17:53:57 PST
Created
attachment 27032
[details]
Initial patch As discussed on IRC, would be great if Dave could check this.
Dave Hyatt
Comment 2
2009-01-28 14:07:25 PST
Comment on
attachment 27032
[details]
Initial patch Looks good.
Nikolas Zimmermann
Comment 3
2009-01-29 13:23:27 PST
Landed in
r40370
.
Lucas Forschler
Comment 4
2019-02-06 09:03:23 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug