RESOLVED FIXED 235383
[EWS] Use token when processing hook 
https://bugs.webkit.org/show_bug.cgi?id=235383
Summary [EWS] Use token when processing hook
Jonathan Bedard
Reported 2022-01-19 14:31:51 PST
buildbot may make a GET request to GitHub when processing a GitHub hook. We should provide our authentication token when making this request so the build-master doesn't get throttled.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-01-19 14:32:06 PST
<rdar://problem/87791577>
Aakash Jain
Comment 2 2022-01-19 15:07:26 PST
> buildbot may make a GET request to GitHub when processing a GitHub hook. Can you please elaborate more on this? Why is a outgoing network request needed to process incoming data?
Jonathan Bedard
Comment 3 2022-01-19 16:45:34 PST
(In reply to Aakash Jain from comment #2) > > buildbot may make a GET request to GitHub when processing a GitHub hook. > Can you please elaborate more on this? Why is a outgoing network request > needed to process incoming data? Looks like buildbot reaches out to the GitHub API to search commit messages for a skip pattern: https://github.com/buildbot/buildbot/blob/b856c90fb15e156903228f9a461f4ac8051d70cf/master/buildbot/www/hooks/github.py
Jonathan Bedard
Comment 4 2022-01-20 13:24:21 PST
Doing https://bugs.webkit.org/show_bug.cgi?id=235417 instead of this.
Jonathan Bedard
Comment 5 2022-01-21 12:31:34 PST
Landed 246270@main (r288368)
Note You need to log in before you can comment on or make changes to this bug.