Bug 235379 – Turn EUnicodeBidi into an enum class

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[alan]

ssia

[alan]

Created attachment 449509 [details]
Patch

[alan]

Created attachment 449512 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 449512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449512&action=review

> Source/WebCore/platform/text/UnicodeBidi.h:31
> +enum class EUnicodeBidi : uint8_t {

Can we drop the E prefix?

[alan]

(In reply to zalan from comment #2)
> Created attachment 449512 [details]
> Patch
Good point!

[Antti Koivisto]

Comment on attachment 449512 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449512&action=review

>> Source/WebCore/platform/text/UnicodeBidi.h:31
>> +enum class EUnicodeBidi : uint8_t {
> 
> Can we drop the E prefix?

We should.

[alan]

Created attachment 449516 [details]
Patch

[EWS]

Committed r288254 (246204@main): <https://commits.webkit.org/246204@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449516 [details].

[Radar WebKit Bug Importer]

<rdar://problem/87799957>

[Darin Adler]

Comment on attachment 449516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449516&action=review

> Source/WebCore/platform/text/UnicodeBidi.h:32
>      UBNormal,

Need to rename this to just "Normal" now that it’s in an enum class and will always appear as UnicodeBidi::Normal.

[alan]

(In reply to Darin Adler from comment #9)
> Comment on attachment 449516 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449516&action=review
> 
> > Source/WebCore/platform/text/UnicodeBidi.h:32
> >      UBNormal,
> 
> Need to rename this to just "Normal" now that it’s in an enum class and will
> always appear as UnicodeBidi::Normal.
Oh I missed that. Thanks!

[alan]

Created attachment 449544 [details]
Patch

address post-landing feedback.

[alan]

see above

[EWS]

/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[alan]

Created attachment 449572 [details]
Patch

[EWS]

Committed r288291 (246216@main): <https://commits.webkit.org/246216@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449572 [details].