WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 235716
Bug 235374
ValidatePatch shouldn't fetch the same PR information twice
https://bugs.webkit.org/show_bug.cgi?id=235374
Summary
ValidatePatch shouldn't fetch the same PR information twice
Aakash Jain
Reported
2022-01-19 12:36:54 PST
ValidatePatch shouldn't fetch the same PR information twice. Currently it is fetching same information twice, both _is_pr_closed() and _is_pr_obsolete() methods call get_pr_json() which does network call to github to fetch PR information. Two calls to same url can be seen in
https://ews-build.webkit-uat.org/#/builders/1/builds/1694/steps/3/logs/stdio
This code was added recently in
https://commits.webkit.org/246047@main
(
https://github.com/WebKit/WebKit/pull/62
).
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2022-01-26 12:37:17 PST
<
rdar://problem/88090121
>
Jonathan Bedard
Comment 2
2022-03-09 10:28:19 PST
*** This bug has been marked as a duplicate of
bug 235716
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug