Bug 235374 - ValidatePatch shouldn't fetch the same PR information twice
Summary: ValidatePatch shouldn't fetch the same PR information twice
Status: RESOLVED DUPLICATE of bug 235716
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-19 12:36 PST by Aakash Jain
Modified: 2022-03-09 10:28 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-01-19 12:36:54 PST 
ValidatePatch shouldn't fetch the same PR information twice. Currently it is fetching same information twice, both _is_pr_closed() and _is_pr_obsolete() methods call get_pr_json() which does network call to github to fetch PR information. Two calls to same url can be seen in https://ews-build.webkit-uat.org/#/builders/1/builds/1694/steps/3/logs/stdio
This code was added recently in https://commits.webkit.org/246047@main (https://github.com/WebKit/WebKit/pull/62).
Comment 1 Radar WebKit Bug Importer 2022-01-26 12:37:17 PST 
<rdar://problem/88090121>
Comment 2 Jonathan Bedard 2022-03-09 10:28:19 PST 

*** This bug has been marked as a duplicate of bug 235716 ***