Bug 235363 - [Model] Mouse interaction for <model> is flipped in the y-axis
Summary: [Model] Mouse interaction for <model> is flipped in the y-axis
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-19 06:25 PST by Antoine Quint
Modified: 2022-01-26 01:26 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.15 KB, patch)
2022-01-19 06:27 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (13.64 KB, patch)
2022-01-26 00:23 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-01-19 06:25:37 PST 
[Model] Mouse interaction for <model> is flipped in the y-axis
Comment 1 Antoine Quint 2022-01-19 06:27:42 PST 
Created attachment 449478 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-01-19 08:37:16 PST 
<rdar://problem/87772557>
Comment 3 Dean Jackson 2022-01-19 08:49:19 PST 
Comment on attachment 449478 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449478&action=review

> Source/WebKit/ChangeLog:9
> +        The mouse coordinates come from the Web page but are consumed by ARQL, so we need
> +        to flip coordinates in the y-axis.

Don't we have to flip by doing (height - location) rather than just (-location)?
Comment 4 Antoine Quint 2022-01-26 00:23:40 PST 
Created attachment 449999 [details]
Patch for landing
Comment 5 EWS 2022-01-26 01:26:34 PST 
Committed r288610 (246429@main): <https://commits.webkit.org/246429@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449999 [details].