Bug 235352 - TestRunner.setMockCameraOrientation cannot set 270
Summary: TestRunner.setMockCameraOrientation cannot set 270
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 235233
Blocks:
  Show dependency tree / graph
 
Reported: 2022-01-19 02:51 PST by Kimmo Kinnunen
Modified: 2022-01-26 02:52 PST (History)
4 users (show)

See Also:

Attachments
Patch (29.51 KB, patch)
2022-01-20 11:19 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-01-19 02:51:59 PST 
TestRunner.setMockCameraOrientation cannot set 270

it should be settable via -90 but the C++ part is unsigned
Comment 1 Kimmo Kinnunen 2022-01-20 11:19:14 PST 
Created attachment 449597 [details]
Patch
Comment 2 youenn fablet 2022-01-21 03:08:00 PST 
Comment on attachment 449597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449597&action=review

> Source/WebKit/ChangeLog:12
> +        For untrusted IPC APIs, add a if check.

It seems passing an enum like MediaSample::VideoRotation (maybe we should promote this enum to a standalone one) would help.
Comment 3 Radar WebKit Bug Importer 2022-01-26 02:52:28 PST 
<rdar://problem/88067253>