Bug 235334 - Speedometer should be locally runnable on Windows
Summary: Speedometer should be locally runnable on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-18 14:36 PST by Ross Kirsling
Modified: 2022-01-18 15:42 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2022-01-18 14:43 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch for landing (1.42 KB, patch)
2022-01-18 14:51 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2022-01-18 14:36:32 PST 
Speedometer should be locally runnable on Windows
Comment 1 Ross Kirsling 2022-01-18 14:43:57 PST 
Created attachment 449427 [details]
Patch
Comment 2 Don Olmstead 2022-01-18 14:47:42 PST 
Comment on attachment 449427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449427&action=review

r=me

> PerformanceTests/.gitattributes:8
> +Speedometer/resources/todomvc/architecture-examples/emberjs/dist/assets/todomvc-5d3e8eb3d5b3740a33185edcb11eeb57.js -crlf
> +Speedometer/resources/todomvc/architecture-examples/emberjs/dist/assets/vendor-820919567eb7bd4d9fac358a90a5aac4.js -crlf

My only concern is that the hash would be updated and then this issue would crop up again but that's minor.
Comment 3 Ross Kirsling 2022-01-18 14:51:01 PST 
(In reply to Don Olmstead from comment #2)
> Comment on attachment 449427 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449427&action=review
> 
> r=me
> 
> > PerformanceTests/.gitattributes:8
> > +Speedometer/resources/todomvc/architecture-examples/emberjs/dist/assets/todomvc-5d3e8eb3d5b3740a33185edcb11eeb57.js -crlf
> > +Speedometer/resources/todomvc/architecture-examples/emberjs/dist/assets/vendor-820919567eb7bd4d9fac358a90a5aac4.js -crlf
> 
> My only concern is that the hash would be updated and then this issue would
> crop up again but that's minor.

Good call, I think I can use *.js instead.
Comment 4 Ross Kirsling 2022-01-18 14:51:39 PST 
Created attachment 449430 [details]
Patch for landing
Comment 5 EWS 2022-01-18 15:41:33 PST 
Committed r288154 (246149@main): <https://commits.webkit.org/246149@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449430 [details].
Comment 6 Radar WebKit Bug Importer 2022-01-18 15:42:17 PST 
<rdar://problem/87739252>