Bug 235280 - [libpas] medium directory lookup should bail if begin_index is zero to catch races with expendable memory decommit (cherry pick 434465bfb8e0c285d6763cf6aa0e04982199f824)
Summary: [libpas] medium directory lookup should bail if begin_index is zero to catch ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-16 11:58 PST by Filip Pizlo
Modified: 2022-01-20 18:44 PST (History)
3 users (show)

See Also:

Attachments
the patch (30.77 KB, patch)
2022-01-16 12:06 PST, Filip Pizlo 		ysuzuki: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
better patch (53.20 KB, patch)
2022-01-18 20:28 PST, Filip Pizlo 		ysuzuki: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2022-01-16 11:58:24 PST 
...
Comment 1 Filip Pizlo 2022-01-16 11:58:41 PST 
<rdar://87249133>
Comment 2 Filip Pizlo 2022-01-16 12:06:45 PST 
Created attachment 449285 [details]
the patch
Comment 3 Yusuke Suzuki 2022-01-18 01:06:37 PST 
Comment on attachment 449285 [details]
the patch

r=me
Comment 4 Filip Pizlo 2022-01-18 20:28:15 PST 
Created attachment 449461 [details]
better patch

When I tested the previous patch against the tests in the updated libpas (bug 235347), I found a bunch of issues. This fixes all of them, I think?
Comment 5 Yusuke Suzuki 2022-01-20 17:02:39 PST 
Comment on attachment 449461 [details]
better patch

r=me
Comment 6 Filip Pizlo 2022-01-20 18:44:09 PST 
Landed in https://trac.webkit.org/changeset/288342/webkit