Bug 235273 - [GTK][STABLE] Missing headers for non-unified 2.34.3 build
Summary: [GTK][STABLE] Missing headers for non-unified 2.34.3 build
Status: RESOLVED DUPLICATE of bug 235444
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2022-01-15 13:36 PST by Dennis Nezic
Modified: 2022-01-23 13:45 PST (History)
3 users (show)

See Also:

missing headers patch (2.15 KB, patch)
2022-01-15 13:37 PST, Dennis Nezic
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Nezic 2022-01-15 13:36:45 PST
These missing #include's caused my non-unified compilation to fail.
Comment 1 Dennis Nezic 2022-01-15 13:37:24 PST
Created attachment 449268 [details]
missing headers patch
Comment 2 Dennis Nezic 2022-01-15 14:37:30 PST
WebCore/css/calc/CSSCalcOperationNode.cpp and ebCore/css/calc/CSSCalcPrimitiveValueNode.cpp weren't able to see the definition of LOG_WITH_STREAM()

WebCore/page/EventHandler.cpp wasn't able to recognize SetForScope()

WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h wasn't able to recognize WebCore::FloatPoint ... but apparently only #if PLATFORM(GTK) ... so we should probably update the patch.
It also wasn't able to find #include <WebCore/CoordinatedGraphicsLayer.h>, so I guess that needed to be wrapped in that additional #if USE(COORDINATED_GRAPHICS)

WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h didn't recognize adjustTransientZoom() and commitTransientZoom()
Comment 3 Michael Catanzaro 2022-01-21 13:45:23 PST
Please include a ChangeLog and make sure it passes EWS (patch must apply to trunk). Then you can separately submit a patch for the stable branch (which of course doesn't need to pass EWS).
Comment 4 Dennis Nezic 2022-01-23 13:45:49 PST

*** This bug has been marked as a duplicate of bug 235444 ***