[JSC] Fix misc issues in WebAssembly.Exception
Created attachment 449239 [details] Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment on attachment 449239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449239&action=review > LayoutTests/imported/w3c/web-platform-tests/wasm/jsapi/exception/getArg.tentative.any.js:23 > + assert_throws_js(TypeError, () => exn.getArg(tag, 1)); According to the spec, it should be TypeError https://webassembly.github.io/exception-handling/js-api/index.html#dom-exception-getarg
Created attachment 449242 [details] Patch
Created attachment 449246 [details] Patch
Comment on attachment 449246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449246&action=review r=me with ChangeLog nits. > Source/JavaScriptCore/ChangeLog:10 > + 3. Throw TypeError instead of RangeError when implementing [EnforceRange] extended attribute (step 6 of https://webidl.spec.whatwg.org/#abstract-opdef-converttoint). Also, a link to proposal spec would be nice: https://github.com/WebAssembly/exception-handling/blob/main/proposals/exception-handling/Exceptions.md#js-api.
(In reply to Alexey Shvayka from comment #6) > 3. Throw TypeError instead of RangeError when implementing [EnforceRange] > extended attribute (step 6 of > https://webidl.spec.whatwg.org/#abstract-opdef-converttoint). > > Also, a link to proposal spec would be nice: > https://github.com/WebAssembly/exception-handling/blob/main/proposals/ > exception-handling/Exceptions.md#js-api. Oops, that's not [EnforceRange], sorry, and the spec link from WPT PR is way better.
(In reply to Alexey Shvayka from comment #7) > (In reply to Alexey Shvayka from comment #6) > > 3. Throw TypeError instead of RangeError when implementing [EnforceRange] > > extended attribute (step 6 of > > https://webidl.spec.whatwg.org/#abstract-opdef-converttoint). > > > > Also, a link to proposal spec would be nice: > > https://github.com/WebAssembly/exception-handling/blob/main/proposals/ > > exception-handling/Exceptions.md#js-api. > > Oops, that's not [EnforceRange], sorry, and the spec link from WPT PR is way > better. OK, added!
Committed r288065 (246085@trunk): <https://commits.webkit.org/246085@trunk>
<rdar://problem/87641664>