Bug 235258 - First step to fix hacked isReplaced: Rename isReplaced functions to isReplacedOrInlineBlock
Summary: First step to fix hacked isReplaced: Rename isReplaced functions to isReplace...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-14 16:57 PST by Darin Adler
Modified: 2022-01-15 14:30 PST (History)
27 users (show)

See Also:

Attachments
Patch (62.71 KB, patch)
2022-01-14 17:11 PST, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (63.81 KB, patch)
2022-01-14 17:20 PST, Darin Adler 		zalan: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (64.67 KB, patch)
2022-01-15 14:01 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2022-01-14 16:57:36 PST 
First step to fix hacked isReplaced: Rename isReplaced functions to isReplacedOrInlineBlock
Comment 1 Darin Adler 2022-01-14 17:11:57 PST Comment hidden (obsolete)
Comment 2 Darin Adler 2022-01-14 17:20:01 PST 
Created attachment 449235 [details]
Patch
Comment 3 zalan 2022-01-14 18:46:17 PST 
Comment on attachment 449235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449235&action=review

> Source/WebCore/rendering/RenderReplica.cpp:48
> +    // FIXME: Is the comment above obsolete? Can't find a check of isReplacedOrInlineBlock guarding setHasTransform any more.
> +    setReplacedOrInlineBlock(true);

Curious.
Comment 4 Darin Adler 2022-01-15 14:01:05 PST 
Created attachment 449269 [details]
Patch for landing
Comment 5 Darin Adler 2022-01-15 14:29:35 PST 
Committed r288067 (?): <https://commits.webkit.org/r288067>
Comment 6 Radar WebKit Bug Importer 2022-01-15 14:30:18 PST 
<rdar://problem/87642166>