Bug 235253 - AX: Remove AXAriaAttributeChanged notification because it's not used by anything
Summary: AX: Remove AXAriaAttributeChanged notification because it's not used by anything
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-14 14:35 PST by Tyler Wilcock
Modified: 2022-01-15 09:12 PST (History)
11 users (show)

See Also:


Attachments
Patch (3.99 KB, patch)
2022-01-14 14:37 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-01-14 14:35:56 PST
Nothing uses AXAriaAttributeChanged, but we still spend time processing it through the notification pipeline (postNotification -> m_notificationsToPost -> updateIsolatedTree(notifications) + postPlatformNotification(notifications)).
Comment 1 Radar WebKit Bug Importer 2022-01-14 14:36:28 PST
<rdar://problem/87619004>
Comment 2 Tyler Wilcock 2022-01-14 14:37:58 PST
Created attachment 449227 [details]
Patch
Comment 3 chris fleizach 2022-01-14 14:40:50 PST
Comment on attachment 449227 [details]
Patch

we're sure GTK/Win don't use this?
Comment 4 Tyler Wilcock 2022-01-14 14:48:38 PST
Yeah, quite sure. Windows doesn't handle it, and doesn't have a fallthrough in postPlatformNotification for notifications that aren't explicitly handled by name (it returns early if given an unexpected notification). ATK / ATSPI seems to be the same, but CC'd Carlos to confirm.

Carlos, can you confirm that the ATK / ATSPI ports don't and won't use this?
Comment 5 chris fleizach 2022-01-14 14:50:00 PST
(In reply to Tyler Wilcock from comment #4)
> Yeah, quite sure. Windows doesn't handle it, and doesn't have a fallthrough
> in postPlatformNotification for notifications that aren't explicitly handled
> by name (it returns early if given an unexpected notification). ATK / ATSPI
> seems to be the same, but CC'd Carlos to confirm.
> 
> Carlos, can you confirm that the ATK / ATSPI ports don't and won't use this?

Ok if we pass all the builds probably ok. It can always be added back if we need it
Comment 6 EWS 2022-01-15 09:12:40 PST
Committed r288056 (246076@main): <https://commits.webkit.org/246076@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449227 [details].