Bug 235253 – AX: Remove AXAriaAttributeChanged notification because it's not used by anything

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

Nothing uses AXAriaAttributeChanged, but we still spend time processing it through the notification pipeline (postNotification -> m_notificationsToPost -> updateIsolatedTree(notifications) + postPlatformNotification(notifications)).

[Radar WebKit Bug Importer]

<rdar://problem/87619004>

[Tyler Wilcock]

Created attachment 449227 [details]
Patch

[chris fleizach]

Comment on attachment 449227 [details]
Patch

we're sure GTK/Win don't use this?

[Tyler Wilcock]

Yeah, quite sure. Windows doesn't handle it, and doesn't have a fallthrough in postPlatformNotification for notifications that aren't explicitly handled by name (it returns early if given an unexpected notification). ATK / ATSPI seems to be the same, but CC'd Carlos to confirm.

Carlos, can you confirm that the ATK / ATSPI ports don't and won't use this?

[chris fleizach]

(In reply to Tyler Wilcock from comment #4)
> Yeah, quite sure. Windows doesn't handle it, and doesn't have a fallthrough
> in postPlatformNotification for notifications that aren't explicitly handled
> by name (it returns early if given an unexpected notification). ATK / ATSPI
> seems to be the same, but CC'd Carlos to confirm.
> 
> Carlos, can you confirm that the ATK / ATSPI ports don't and won't use this?

Ok if we pass all the builds probably ok. It can always be added back if we need it

[EWS]

Committed r288056 (246076@main): <https://commits.webkit.org/246076@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449227 [details].