Bug 235242 - Share some code that looks at visibility in order to short-circuit repaint rect computation
Summary: Share some code that looks at visibility in order to short-circuit repaint re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-14 11:41 PST by Simon Fraser (smfr)
Modified: 2022-01-15 11:26 PST (History)
16 users (show)

See Also:

Attachments
Patch (7.32 KB, patch)
2022-01-14 11:42 PST, Simon Fraser (smfr) 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2022-01-14 11:41:17 PST 
Share some code that looks at visibility in order to short-circuit repaint rect computation
Comment 1 Simon Fraser (smfr) 2022-01-14 11:42:33 PST 
Created attachment 449193 [details]
Patch
Comment 2 zalan 2022-01-14 12:31:55 PST 
Comment on attachment 449193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449193&action=review

> Source/WebCore/rendering/RenderObject.cpp:455
> +bool RenderObject::isInsideEntirelyHiddenLayer() const
> +{
> +    return style().visibility() != Visibility::Visible && !enclosingLayer()->hasVisibleContent();
> +}

Does it have to be on RenderObject?
Comment 3 Simon Fraser (smfr) 2022-01-14 12:35:01 PST 
Comment on attachment 449193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449193&action=review

>> Source/WebCore/rendering/RenderObject.cpp:455
>> +}
> 
> Does it have to be on RenderObject?

Looks like it could be on RenderBox. Will fix.
Comment 4 Simon Fraser (smfr) 2022-01-15 11:25:34 PST 
https://trac.webkit.org/changeset/288060/webkit
Comment 5 Radar WebKit Bug Importer 2022-01-15 11:26:17 PST 
<rdar://problem/87640393>