Bug 235235 - Use IRC for Wasm, and Briggs for JS on ARM64
Summary: Use IRC for Wasm, and Briggs for JS on ARM64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-14 10:14 PST by Saam Barati
Modified: 2022-01-14 12:06 PST (History)
8 users (show)

See Also:


Attachments
patch (3.65 KB, patch)
2022-01-14 10:26 PST, Saam Barati
ysuzuki: review+
Details | Formatted Diff | Diff
patch for landing (3.78 KB, patch)
2022-01-14 11:24 PST, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2022-01-14 10:14:30 PST
Seeing some regressions from https://trac.webkit.org/changeset/287218/webkit by always using IRC
Comment 1 Saam Barati 2022-01-14 10:15:22 PST
<rdar://87090631>
Comment 2 Saam Barati 2022-01-14 10:20:31 PST
(In reply to Saam Barati from comment #0)
> Seeing some regressions from https://trac.webkit.org/changeset/287218/webkit
> by always using IRC

Regressions on iOS on JetStream2
Comment 3 Saam Barati 2022-01-14 10:26:41 PST
Created attachment 449182 [details]
patch
Comment 4 Yusuke Suzuki 2022-01-14 10:29:06 PST
Comment on attachment 449182 [details]
patch

r=me
Comment 5 Robin Morisset 2022-01-14 10:32:04 PST
Comment on attachment 449182 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449182&action=review

r=me

> Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp:1823
> +                if (isARM64())

Maybe just return !isArm64(); ?

> Source/JavaScriptCore/b3/air/AirCode.h:416
> +    bool m_forceIRC { false };

It probably does not really matter, but moving it with the other bools would save a word of memory.
Comment 6 Saam Barati 2022-01-14 11:23:28 PST
Comment on attachment 449182 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449182&action=review

>> Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp:1823
>> +                if (isARM64())
> 
> Maybe just return !isArm64(); ?

as silly as this is, I find the current way slightly easier to read and add new conditions to later.

>> Source/JavaScriptCore/b3/air/AirCode.h:416
>> +    bool m_forceIRC { false };
> 
> It probably does not really matter, but moving it with the other bools would save a word of memory.

will fix
Comment 7 Saam Barati 2022-01-14 11:24:33 PST
Created attachment 449191 [details]
patch for landing
Comment 8 EWS 2022-01-14 12:06:52 PST
Committed r288023 (246049@main): <https://commits.webkit.org/246049@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449191 [details].