Bug 235235 – Use IRC for Wasm, and Briggs for JS on ARM64

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

Seeing some regressions from https://trac.webkit.org/changeset/287218/webkit by always using IRC

[Saam Barati]

<rdar://87090631>

[Saam Barati]

(In reply to Saam Barati from comment #0)
> Seeing some regressions from https://trac.webkit.org/changeset/287218/webkit
> by always using IRC

Regressions on iOS on JetStream2

[Saam Barati]

Created attachment 449182 [details]
patch

[Yusuke Suzuki]

Comment on attachment 449182 [details]
patch

r=me

[Robin Morisset]

Comment on attachment 449182 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449182&action=review

r=me

> Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp:1823
> +                if (isARM64())

Maybe just return !isArm64(); ?

> Source/JavaScriptCore/b3/air/AirCode.h:416
> +    bool m_forceIRC { false };

It probably does not really matter, but moving it with the other bools would save a word of memory.

[Saam Barati]

Comment on attachment 449182 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449182&action=review

>> Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp:1823
>> +                if (isARM64())
> 
> Maybe just return !isArm64(); ?

as silly as this is, I find the current way slightly easier to read and add new conditions to later.

>> Source/JavaScriptCore/b3/air/AirCode.h:416
>> +    bool m_forceIRC { false };
> 
> It probably does not really matter, but moving it with the other bools would save a word of memory.

will fix

[Saam Barati]

Created attachment 449191 [details]
patch for landing

[EWS]

Committed r288023 (246049@main): <https://commits.webkit.org/246049@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449191 [details].