Bug 235226 - Frequent GPU process jetsams due to RemoteRenderingBackendProxy not claiming ownership of SharedMemory buffers
Summary: Frequent GPU process jetsams due to RemoteRenderingBackendProxy not claiming ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 232727
  Show dependency tree / graph
 
Reported: 2022-01-14 04:25 PST by Kimmo Kinnunen
Modified: 2022-01-17 00:22 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.15 KB, patch)
2022-01-14 08:14 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (5.69 KB, patch)
2022-01-14 12:21 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (5.15 KB, patch)
2022-01-15 03:52 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-01-14 04:25:16 PST 
Frequent GPU process jetsams due to RemoteRenderingBackendProxy not claiming ownership of SharedMemory buffers
Comment 1 Kimmo Kinnunen 2022-01-14 08:14:31 PST 
Created attachment 449173 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-01-14 08:18:55 PST 
<rdar://problem/87601499>
Comment 3 Simon Fraser (smfr) 2022-01-14 08:47:38 PST 
Comment on attachment 449173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449173&action=review

> Source/WebKit/Shared/ShareableBitmap.cpp:46
> +    m_handle.takeOwnershipOfMemory(ledger);

Should this assert that m_handle has an m_port already (otherwise the call is a no-op)?
Comment 4 Kimmo Kinnunen 2022-01-14 12:21:56 PST 
Created attachment 449202 [details]
Patch
Comment 5 Kimmo Kinnunen 2022-01-15 03:52:44 PST 
Created attachment 449251 [details]
Patch
Comment 6 Kimmo Kinnunen 2022-01-15 03:53:43 PST 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 449173 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449173&action=review
> 
> > Source/WebKit/Shared/ShareableBitmap.cpp:46
> > +    m_handle.takeOwnershipOfMemory(ledger);
> 
> Should this assert that m_handle has an m_port already (otherwise the call
> is a no-op)?

Logically if ShareableBitmap should assert, so should SharedMemory.
Filed bug 235264 because of apparent existing bugs
Comment 7 EWS 2022-01-17 00:22:34 PST 
Committed r288090 (246104@main): <https://commits.webkit.org/246104@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449251 [details].