Bug 235226 – Frequent GPU process jetsams due to RemoteRenderingBackendProxy not claiming ownership of SharedMemory buffers

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Kimmo Kinnunen]

Frequent GPU process jetsams due to RemoteRenderingBackendProxy not claiming ownership of SharedMemory buffers

[Kimmo Kinnunen]

Created attachment 449173 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/87601499>

[Simon Fraser (smfr)]

Comment on attachment 449173 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449173&action=review

> Source/WebKit/Shared/ShareableBitmap.cpp:46
> +    m_handle.takeOwnershipOfMemory(ledger);

Should this assert that m_handle has an m_port already (otherwise the call is a no-op)?

[Kimmo Kinnunen]

Created attachment 449202 [details]
Patch

[Kimmo Kinnunen]

Created attachment 449251 [details]
Patch

[Kimmo Kinnunen]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 449173 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=449173&action=review
> 
> > Source/WebKit/Shared/ShareableBitmap.cpp:46
> > +    m_handle.takeOwnershipOfMemory(ledger);
> 
> Should this assert that m_handle has an m_port already (otherwise the call
> is a no-op)?

Logically if ShareableBitmap should assert, so should SharedMemory.
Filed bug 235264 because of apparent existing bugs

[EWS]

Committed r288090 (246104@main): <https://commits.webkit.org/246104@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449251 [details].