RESOLVED FIXED 235217
JSStringJoiner's constructor should take a size_t length. 
https://bugs.webkit.org/show_bug.cgi?id=235217
Summary JSStringJoiner's constructor should take a size_t length.
Mark Lam
Reported 2022-01-13 20:14:08 PST
This allows underlying code to do a proper limit check on the length. rdar://87538657
Attachments
proposed patch. (4.07 KB, patch)
2022-01-13 20:20 PST, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
[fast-cq] patch for landing. (4.14 KB, patch)
2022-01-13 23:04 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.01 KB, patch)
2022-01-19 07:40 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2022-01-13 20:20:28 PST
Created attachment 449131 [details] proposed patch.
Mark Lam
Comment 2 2022-01-13 23:04:16 PST
Created attachment 449142 [details] [fast-cq] patch for landing.
Mark Lam
Comment 3 2022-01-14 16:42:36 PST
Comment on attachment 449142 [details] [fast-cq] patch for landing. Thanks for the review. Landing now.
EWS
Comment 4 2022-01-14 16:45:31 PST
Committed r288037 (246063@main): <https://commits.webkit.org/246063@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449142 [details].
Michael Catanzaro
Comment 5 2022-01-17 07:32:35 PST
Hi, there is a problem with this test when running with cloop: Running stress/max-typed-array-length-toString.js.default stress/max-typed-array-length-toString.js.default: Exception: FAILED: ReferenceError: Can't find variable: WebAssembly stress/max-typed-array-length-toString.js.default: ERROR: Unexpected exit code: 3 FAIL: stress/max-typed-array-length-toString.js.default Running stress/max-typed-array-length-toString.js.bytecode-cache stress/max-typed-array-length-toString.js.bytecode-cache: Exception: FAILED: ReferenceError: Can't find variable: WebAssembly I think WebAssembly is incompatible with cloop, is that right? Can we skip the test somehow in this case?
Mark Lam
Comment 6 2022-01-18 10:15:45 PST
(In reply to Michael Catanzaro from comment #5) > I think WebAssembly is incompatible with cloop, is that right? Can we skip > the test somehow in this case? Fixed in r288120: <http://trac.webkit.org/r288120>.
Michael Catanzaro
Comment 7 2022-01-18 13:55:48 PST
Thanks Mark!
Michael Catanzaro
Comment 8 2022-01-19 06:32:02 PST
The test is actually still failing: Crashing because current footprint: 637390848 exceeds limit: 629145600 I will skip it if memory limited.
Michael Catanzaro
Comment 9 2022-01-19 07:40:47 PST
Reopening to attach new patch.
Michael Catanzaro
Comment 10 2022-01-19 07:40:50 PST
Created attachment 449483 [details] Patch for landing
EWS
Comment 11 2022-01-19 09:46:23 PST
Committed r288213 (246174@main): <https://commits.webkit.org/246174@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449483 [details].
Note You need to log in before you can comment on or make changes to this bug.