Bug 235204 - AX: Move methods that are unnecessarily in AccessibilityRenderObject to AccessibilityNodeObject (part 1 / n)
Summary: AX: Move methods that are unnecessarily in AccessibilityRenderObject to Acces...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-13 14:21 PST by Tyler Wilcock
Modified: 2022-01-14 09:07 PST (History)
10 users (show)

See Also:


Attachments
Patch (17.21 KB, patch)
2022-01-13 14:27 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff
Patch (17.21 KB, patch)
2022-01-13 15:36 PST, Tyler Wilcock
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-01-13 14:21:36 PST
Many methods in AccessibilityRenderObject don't actually do anything renderer-specific, and thus should be in the base class AccessibilityNodeObject. This will help improve our support for AX objects that normally have renderers, but don't because of CSS or ARIA markup (e.g. display: contents).
Comment 1 Radar WebKit Bug Importer 2022-01-13 14:21:48 PST
<rdar://problem/87570504>
Comment 2 Tyler Wilcock 2022-01-13 14:27:17 PST
Created attachment 449111 [details]
Patch
Comment 3 chris fleizach 2022-01-13 14:34:27 PST
Comment on attachment 449111 [details]
Patch

can we add a test here that fixes some aspect of display: contents
Comment 4 Tyler Wilcock 2022-01-13 14:42:53 PST
Not with this patch. display: contents elements currently have no representation in the tree, so there is no element to test against. I have a WIP patch that makes them part of the tree, but it would require a fair amount more work before becoming something coherent and landable.

What the above patch does is prepare us for when display: contents nodes are part of the tree by moving node-only functionality to AccessibilityNodeObject, as display contents elements won’t have renderers.
Comment 5 Tyler Wilcock 2022-01-13 15:36:26 PST
Created attachment 449121 [details]
Patch
Comment 6 EWS 2022-01-14 08:41:41 PST
Committed r288018 (246044@main): <https://commits.webkit.org/246044@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449121 [details].