Bug 235204 – AX: Move methods that are unnecessarily in AccessibilityRenderObject to AccessibilityNodeObject (part 1 / n)

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

Many methods in AccessibilityRenderObject don't actually do anything renderer-specific, and thus should be in the base class AccessibilityNodeObject. This will help improve our support for AX objects that normally have renderers, but don't because of CSS or ARIA markup (e.g. display: contents).

[Radar WebKit Bug Importer]

<rdar://problem/87570504>

[Tyler Wilcock]

Created attachment 449111 [details]
Patch

[chris fleizach]

Comment on attachment 449111 [details]
Patch

can we add a test here that fixes some aspect of display: contents

[Tyler Wilcock]

Not with this patch. display: contents elements currently have no representation in the tree, so there is no element to test against. I have a WIP patch that makes them part of the tree, but it would require a fair amount more work before becoming something coherent and landable.

What the above patch does is prepare us for when display: contents nodes are part of the tree by moving node-only functionality to AccessibilityNodeObject, as display contents elements won’t have renderers.

[Tyler Wilcock]

Created attachment 449121 [details]
Patch

[EWS]

Committed r288018 (246044@main): <https://commits.webkit.org/246044@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449121 [details].