Bug 235201 – Link Wasm code on the same thread that JITs

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Yusuke Suzuki]

THAT IS AWESOME!!!!!!!

[Saam Barati]

Created attachment 449114 [details]
patch

[Yusuke Suzuki]

Comment on attachment 449114 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449114&action=review

r=me

> Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:201
> +        auto result = m_embedderToWasmInternalFunctions.add(functionIndex, std::pair<std::unique_ptr<LinkBuffer>, std::unique_ptr<InternalFunction>> { WTFMove(linkBuffer), WTFMove(embedderToWasmInternalFunction) });

I think you can use `std::pair { ... }` instead of `std::pair<std::unique_ptr<LinkBuffer>, std::unique_ptr<InternalFunction>>`.

[Mark Lam]

Comment on attachment 449114 [details]
patch

r=me too.

[Saam Barati]

Comment on attachment 449114 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449114&action=review

>> Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:201
>> +        auto result = m_embedderToWasmInternalFunctions.add(functionIndex, std::pair<std::unique_ptr<LinkBuffer>, std::unique_ptr<InternalFunction>> { WTFMove(linkBuffer), WTFMove(embedderToWasmInternalFunction) });
> 
> I think you can use `std::pair { ... }` instead of `std::pair<std::unique_ptr<LinkBuffer>, std::unique_ptr<InternalFunction>>`.

Nice. I didn't know that. I first tried just "{ ... }", but that failed, so I went with the full type declaration. Will fix.

[Saam Barati]

Created attachment 449118 [details]
patch for landing

[EWS]

Committed r288002 (246028@main): <https://commits.webkit.org/246028@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449118 [details].

[Radar WebKit Bug Importer]

<rdar://problem/87582343>