RESOLVED FIXED 235198
Avoid unnecessary call to windowScreenDidChange
https://bugs.webkit.org/show_bug.cgi?id=235198
Summary Avoid unnecessary call to windowScreenDidChange
Per Arne Vollan
Reported 2022-01-13 13:32:06 PST
It is a page load performance progression to avoid this call.
Attachments
Patch (2.22 KB, patch)
2022-01-13 13:34 PST, Per Arne Vollan
no flags
Per Arne Vollan
Comment 1 2022-01-13 13:33:22 PST
Per Arne Vollan
Comment 2 2022-01-13 13:34:40 PST
Geoffrey Garen
Comment 3 2022-01-13 13:44:01 PST
Comment on attachment 449098 [details] Patch r=me This is a great fix for a regression in trunk. Having fixed the regression, I'm concerned that we've got a ticking time bomb that will regress again when we enable WebAnimationsCustomFrameRate by default. What should we do about that?
Per Arne Vollan
Comment 4 2022-01-13 13:50:03 PST
(In reply to Geoffrey Garen from comment #3) > Comment on attachment 449098 [details] > Patch > > r=me > > This is a great fix for a regression in trunk. > > Having fixed the regression, I'm concerned that we've got a ticking time > bomb that will regress again when we enable WebAnimationsCustomFrameRate by > default. What should we do about that? I can create a new bug for that. Thanks for reviewing!
EWS
Comment 5 2022-01-13 15:05:12 PST
Committed r287995 (246022@main): <https://commits.webkit.org/246022@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449098 [details].
Note You need to log in before you can comment on or make changes to this bug.