Bug 235191 - Expose way to encode CTAP commands with only hash of ClientDataJSON
Summary: Expose way to encode CTAP commands with only hash of ClientDataJSON
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: j_pascoe@apple.com
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-13 10:27 PST by j_pascoe@apple.com
Modified: 2022-01-14 00:03 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.80 KB, patch)
2022-01-13 10:33 PST, j_pascoe@apple.com
no flags Details | Formatted Diff | Diff
Patch (8.97 KB, patch)
2022-01-13 14:17 PST, j_pascoe@apple.com
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description j_pascoe@apple.com 2022-01-13 10:27:10 PST
_WKWebAuthenticationPanel should expose a way to encode CTAP commands with only the hash of ClientDataJSON, as the full value isn't necessary and isn't always available.
Comment 1 Radar WebKit Bug Importer 2022-01-13 10:27:21 PST
<rdar://problem/87557846>
Comment 2 j_pascoe@apple.com 2022-01-13 10:33:53 PST
Created attachment 449083 [details]
Patch
Comment 3 Brent Fulgham 2022-01-13 13:08:05 PST
Comment on attachment 449083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449083&action=review

> Source/WebKit/ChangeLog:9
> +        CTAP command encoding covered by existing tests. 

Do we have test cases for these new calls? Or will those tests be part of a follow-up patch that uses these new commands?
Comment 4 Brent Fulgham 2022-01-13 14:11:53 PST
Comment on attachment 449083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449083&action=review

>> Source/WebKit/ChangeLog:9
>> +        CTAP command encoding covered by existing tests. 
> 
> Do we have test cases for these new calls? Or will those tests be part of a follow-up patch that uses these new commands?

I spoke with Pascoe about this, and he will ensure proper testing is available in follow-up work.
Comment 5 j_pascoe@apple.com 2022-01-13 14:17:04 PST
Created attachment 449109 [details]
Patch
Comment 6 Brent Fulgham 2022-01-13 15:10:08 PST
Comment on attachment 449109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449109&action=review

r=me

> Tools/ChangeLog:3
> +        Expose way to encode CTAP commands with only the hash of ClientDataJSON

Thank you for adding a test!
Comment 7 EWS 2022-01-14 00:03:25 PST
Committed r288010 (246036@main): <https://commits.webkit.org/246036@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449109 [details].