_WKWebAuthenticationPanel should expose a way to encode CTAP commands with only the hash of ClientDataJSON, as the full value isn't necessary and isn't always available.
<rdar://problem/87557846>
Created attachment 449083 [details] Patch
Comment on attachment 449083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449083&action=review > Source/WebKit/ChangeLog:9 > + CTAP command encoding covered by existing tests. Do we have test cases for these new calls? Or will those tests be part of a follow-up patch that uses these new commands?
Comment on attachment 449083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449083&action=review >> Source/WebKit/ChangeLog:9 >> + CTAP command encoding covered by existing tests. > > Do we have test cases for these new calls? Or will those tests be part of a follow-up patch that uses these new commands? I spoke with Pascoe about this, and he will ensure proper testing is available in follow-up work.
Created attachment 449109 [details] Patch
Comment on attachment 449109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449109&action=review r=me > Tools/ChangeLog:3 > + Expose way to encode CTAP commands with only the hash of ClientDataJSON Thank you for adding a test!
Committed r288010 (246036@main): <https://commits.webkit.org/246036@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449109 [details].