Bug 235179 - Transmit network load metrics when service worker is using one of its network load to respond to FetchEvents
Summary: Transmit network load metrics when service worker is using one of its network...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-13 05:01 PST by youenn fablet
Modified: 2022-01-17 00:15 PST (History)
8 users (show)

See Also:

Attachments
Patch (40.05 KB, patch)
2022-01-13 05:06 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (42.07 KB, patch)
2022-01-13 11:08 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (41.98 KB, patch)
2022-01-16 22:26 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (42.64 KB, patch)
2022-01-16 22:27 PST, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-01-13 05:01:51 PST 
Transmit network load metrics when service worker is using one of its network load to respond to FetchEvents
Comment 1 youenn fablet 2022-01-13 05:06:01 PST 
Created attachment 449049 [details]
Patch
Comment 2 youenn fablet 2022-01-13 11:08:12 PST 
Created attachment 449086 [details]
Patch
Comment 3 Darin Adler 2022-01-14 10:24:08 PST 
Comment on attachment 449086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449086&action=review

Assuming there is no performance problem with this additional IPC

> Source/WebCore/Modules/fetch/FetchResponse.h:123
> +    void setNetworkLoadMetrics(const NetworkLoadMetrics& networkLoadMetrics) { m_networkLoadMetrics = networkLoadMetrics; }

Would have named the argument just metrics.

> Source/WebCore/loader/WorkerThreadableLoader.cpp:243
> +void WorkerThreadableLoader::MainThreadBridge::didFinishLoading(ResourceLoaderIdentifier identifier, const NetworkLoadMetrics& networkLoadMetrics)

Here too.
Comment 4 youenn fablet 2022-01-16 22:26:35 PST 
Created attachment 449306 [details]
Patch for landing
Comment 5 youenn fablet 2022-01-16 22:27:47 PST 
Created attachment 449307 [details]
Patch for landing
Comment 6 EWS 2022-01-17 00:05:40 PST 
Committed r288088 (246102@main): <https://commits.webkit.org/246102@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449307 [details].
Comment 7 Radar WebKit Bug Importer 2022-01-17 00:06:20 PST 
<rdar://problem/87668830>