Bug 235154 - Add to Contact menu item does nothing on mac.
Summary: Add to Contact menu item does nothing on mac.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-12 13:51 PST by Megan Gardner
Modified: 2022-01-12 16:01 PST (History)
2 users (show)

See Also:

Attachments
Patch (14.81 KB, patch)
2022-01-12 13:57 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch for landing (14.91 KB, patch)
2022-01-12 15:12 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2022-01-12 13:51:18 PST 
Add to Contact menu item does nothing on mac.
Comment 1 Megan Gardner 2022-01-12 13:54:20 PST 
rdar://80213097
Comment 2 Megan Gardner 2022-01-12 13:57:57 PST 
Created attachment 448993 [details]
Patch
Comment 3 Tim Horton 2022-01-12 14:02:31 PST 
Comment on attachment 448993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448993&action=review

Please make sure there's a bug tracking adopting TextIndicator here instead of just hiding the highlight.

> Source/WebKit/UIProcess/PageClient.h:436
> +    virtual NSView *activeView() const = 0;

In order to make this less tempting, maybe we can call it viewForPresentingRevealPopover?

> Source/WebKit/UIProcess/mac/PageClientImplMac.h:230
> -    NSView *activeView() const;
> +    NSView *activeView() const override;

And then here in the mac impl you'll just turn around and call activeView...
Comment 4 Megan Gardner 2022-01-12 15:12:14 PST 
Created attachment 449003 [details]
Patch for landing
Comment 5 EWS 2022-01-12 16:01:27 PST 
Committed r287959 (245988@main): <https://commits.webkit.org/245988@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 449003 [details].