WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
235128
Clean up MediaPlaybackTargetPicker::Client
https://bugs.webkit.org/show_bug.cgi?id=235128
Summary
Clean up MediaPlaybackTargetPicker::Client
Peng Liu
Reported
2022-01-12 11:44:53 PST
Clean up MediaPlaybackTargetPicker::Client
Attachments
[fast-cq] Patch
(2.36 KB, patch)
2022-01-12 11:48 PST
,
Peng Liu
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Peng Liu
Comment 1
2022-01-12 11:48:43 PST
Created
attachment 448980
[details]
[fast-cq] Patch
Eric Carlson
Comment 2
2022-01-12 11:57:59 PST
Comment on
attachment 448980
[details]
[fast-cq] Patch Can you also make the class `final`?
Peng Liu
Comment 3
2022-01-12 12:22:17 PST
(In reply to Eric Carlson from
comment #2
)
> Comment on
attachment 448980
[details]
> Patch > > Can you also make the class `final`?
Do you mean class `WebMediaSessionManager`? It is the base class of `WebMediaSessionManagerMac`, so we cannot make it `final`.
EWS
Comment 4
2022-01-13 09:17:22 PST
Committed
r287980
(
246009@main
): <
https://commits.webkit.org/246009@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 448980
[details]
.
Radar WebKit Bug Importer
Comment 5
2022-01-13 09:18:19 PST
<
rdar://problem/87553166
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug