Bug 235128 - Clean up MediaPlaybackTargetPicker::Client
Summary: Clean up MediaPlaybackTargetPicker::Client
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-12 11:44 PST by Peng Liu
Modified: 2022-01-13 09:18 PST (History)
7 users (show)

See Also:

Attachments
[fast-cq] Patch (2.36 KB, patch)
2022-01-12 11:48 PST, Peng Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2022-01-12 11:44:53 PST 
Clean up MediaPlaybackTargetPicker::Client
Comment 1 Peng Liu 2022-01-12 11:48:43 PST 
Created attachment 448980 [details]
[fast-cq] Patch
Comment 2 Eric Carlson 2022-01-12 11:57:59 PST 
Comment on attachment 448980 [details]
[fast-cq] Patch

Can you also make the class `final`?
Comment 3 Peng Liu 2022-01-12 12:22:17 PST 
(In reply to Eric Carlson from comment #2)
> Comment on attachment 448980 [details]
> Patch
> 
> Can you also make the class `final`?

Do you mean class `WebMediaSessionManager`? It is the base class of `WebMediaSessionManagerMac`, so we cannot make it `final`.
Comment 4 EWS 2022-01-13 09:17:22 PST 
Committed r287980 (246009@main): <https://commits.webkit.org/246009@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448980 [details].
Comment 5 Radar WebKit Bug Importer 2022-01-13 09:18:19 PST 
<rdar://problem/87553166>