Bug 235117 - Web Inspector should expose newer CSS Animations, CSS Transitions and Web Animations events
Summary: Web Inspector should expose newer CSS Animations, CSS Transitions and Web Ani...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-12 09:06 PST by Antoine Quint
Modified: 2022-01-12 12:26 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.46 KB, patch)
2022-01-12 09:07 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (3.90 KB, patch)
2022-01-12 11:36 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-01-12 09:06:26 PST 
Web Inspector should expose newer CSS Animations and CSS Transitions events
Comment 1 Antoine Quint 2022-01-12 09:07:42 PST 
Created attachment 448949 [details]
Patch
Comment 2 Joseph Pecoraro 2022-01-12 10:49:59 PST 
Comment on attachment 448949 [details]
Patch

Nice! Are there any others we might want to add to this list?
Comment 3 Antoine Quint 2022-01-12 10:58:44 PST 
(In reply to Joseph Pecoraro from comment #2)
> Comment on attachment 448949 [details]
> Patch
> 
> Nice! Are there any others we might want to add to this list?

Well, there are the AnimationPlaybackEvent events, which aren't dispatched on a node but on an Animation object: "remove", "cancel" and "finish". Should they be a part of that list?
Comment 4 Antoine Quint 2022-01-12 11:36:06 PST 
Created attachment 448977 [details]
Patch for landing
Comment 5 Joseph Pecoraro 2022-01-12 12:07:55 PST 
(In reply to Antoine Quint from comment #3)
> (In reply to Joseph Pecoraro from comment #2)
> > Comment on attachment 448949 [details]
> > Patch
> > 
> > Nice! Are there any others we might want to add to this list?
> 
> Well, there are the AnimationPlaybackEvent events, which aren't dispatched
> on a node but on an Animation object: "remove", "cancel" and "finish".
> Should they be a part of that list?

If EventDispatch includes this event name, it should show up in the JavaScript & Events timeline. So I'd think so!

Probably everything in EventNames.h (DOM_EVENT_NAMES_FOR_EACH) could have a better user facing string.
Comment 6 EWS 2022-01-12 12:25:43 PST 
Committed r287945 (245974@main): <https://commits.webkit.org/245974@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448977 [details].
Comment 7 Radar WebKit Bug Importer 2022-01-12 12:26:16 PST 
<rdar://problem/87477449>