Bug 23511 - Move DOMTimer from WebCore/bindings/js to WebCore/page
Summary: Move DOMTimer from WebCore/bindings/js to WebCore/page
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-01-23 17:52 PST by Dmitry Titov
Modified: 2009-01-26 17:03 PST (History)
4 users (show)

See Also:

Patch to move the file (29.04 KB, patch)
2009-01-23 17:58 PST, Dmitry Titov
no flags Details | Formatted Diff | Diff
Updated patch (29.10 KB, patch)
2009-01-26 11:41 PST, Dmitry Titov
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Titov 2009-01-23 17:52:07 PST
DOMTimer, after recent refactoring, does not have any JSC code and is in fact a dom object (derived from ActiveDOMObject). This also will help eliminate the forked version in Chromium.
Comment 1 Dmitry Titov 2009-01-23 17:58:43 PST
Created attachment 26990 [details]
Patch to move the file

Decided to do it in 2 patches, to keep svn history nice.
First patch - only moves the file. 
Second patch will also make Chromium will compile after the next merge.
Comment 2 Dmitry Titov 2009-01-23 18:14:25 PST
In fact, there is nothing else needed except the patch that's attached. The next merge will auto-unfork dom/DOMTimer.h :-)
Comment 3 Alexey Proskuryakov 2009-01-26 00:34:51 PST
If I'm not mistaken, WebCore/dom is actually for DOM Core classes, so DOMTimer should go to WebCore/page. Sam, is this correct?
Comment 4 Sam Weinig 2009-01-26 08:05:53 PST
Yes, page/ would be better.
Comment 5 Dmitry Titov 2009-01-26 11:41:50 PST
Created attachment 27042 [details]
Updated patch

Changed from dom/ to page/
Comment 6 Alexey Proskuryakov 2009-01-26 11:59:47 PST
Comment on attachment 27042 [details]
Updated patch

Comment 7 Dmitry Titov 2009-01-26 17:03:26 PST
Landed in r40271