Bug 235108 - [WPE] Fix building WebXR with ANGLE enabled
Summary: [WPE] Fix building WebXR with ANGLE enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords: InRadar
Depends on: 235064
Blocks:
  Show dependency tree / graph
 
Reported: 2022-01-12 03:52 PST by Chris Lord
Modified: 2022-01-12 08:20 PST (History)
9 users (show)

See Also:

Attachments
Patch (4.74 KB, patch)
2022-01-12 03:59 PST, Chris Lord 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lord 2022-01-12 03:52:24 PST 
Currently WebXR code doesn't build with ANGLE enabled due to assuming that USE(OPENGL_ES) applies to the WebGL context even when USE(ANGLE) is defined.
Comment 1 Chris Lord 2022-01-12 03:59:27 PST 
Created attachment 448928 [details]
Patch
Comment 2 Alejandro G. Castro 2022-01-12 06:52:55 PST 
Comment on attachment 448928 [details]
Patch

LGTM, great! :-)
Comment 3 EWS 2022-01-12 07:05:49 PST 
Committed r287923 (245956@main): <https://commits.webkit.org/245956@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448928 [details].
Comment 4 Radar WebKit Bug Importer 2022-01-12 07:06:22 PST 
<rdar://problem/87456823>