Bug 235102 - [css-flexbox] Import WPT tests - January edition
Summary: [css-flexbox] Import WPT tests - January edition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks: 234564
  Show dependency tree / graph
 
Reported: 2022-01-12 02:28 PST by Sergio Villar Senin
Modified: 2022-01-12 08:57 PST (History)
9 users (show)

See Also:

Attachments
Patch (208.96 KB, patch)
2022-01-12 02:33 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (180.89 KB, patch)
2022-01-12 04:02 PST, Sergio Villar Senin 		rego: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2022-01-12 02:28:24 PST 
[css-flexbox] Import WPT tests - January edition
Comment 1 Sergio Villar Senin 2022-01-12 02:33:13 PST 
Created attachment 448918 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2022-01-12 03:43:44 PST 
Comment on attachment 448918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448918&action=review

> LayoutTests/imported/w3c/resources/resource-files.json:22
> +        "css/css-flexbox/abspos/flex-abspos-staticpos-align-self-safe-001-ref.html",

Mmmm, there are a lot of -ref files here, but they're actually not being imported. Maybe you forgot to git add them.

The problem is that since r287267 we're importing the -ref.html files, and also creating copies as -expected.html. So we end up having duplicates.

I'm not sure what's the best solution, but one option is to revert that patch to run the import script, and generate a patch that doesn't add so many -ref. Other option might be to merge duplicated files (like it has already happened in some folders).
See this comment https://bugs.webkit.org/show_bug.cgi?id=203784#c27 for more info.
Comment 3 Sergio Villar Senin 2022-01-12 04:02:25 PST 
Created attachment 448930 [details]
Patch
Comment 4 Manuel Rego Casasnovas 2022-01-12 07:41:59 PST 
Comment on attachment 448930 [details]
Patch

r=me
Comment 5 Sergio Villar Senin 2022-01-12 08:56:29 PST 
Committed r287927 (?): <https://commits.webkit.org/r287927>
Comment 6 Radar WebKit Bug Importer 2022-01-12 08:57:15 PST 
<rdar://problem/87461795>