WebKit can crash at this position when startOfLine returns null
Created attachment 26984 [details] patch to stop a crasher
no good steps to reproduce listed in the bug, but the backtrace is pretty clear as to what's happening. as a result, i could not devise a layout test to that elicited the crash
http://trac.webkit.org/changeset/40191
Comment on attachment 26984 [details] patch to stop a crasher Seems to me that makeRange should probably return 0 if passed null positions. And plainText already handles the case where the range is 0. So I would suggest fixing this in the makeRange function rather than in the AccessibilityObject class.
Created attachment 26987 [details] new patch based on review
updated patch based on Darin's review
Darin, is this what you had in mind (In reply to comment #4) > (From update of attachment 26984 [details] [review]) > Seems to me that makeRange should probably return 0 if passed null positions. > And plainText already handles the case where the range is 0. So I would suggest > fixing this in the makeRange function rather than in the AccessibilityObject > class. >
Comment on attachment 26987 [details] new patch based on review r=me
http://trac.webkit.org/changeset/40202