Bug 235086 - WebPageProxy destruction should not launch a network process
Summary: WebPageProxy destruction should not launch a network process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-11 15:18 PST by Geoffrey Garen
Modified: 2022-01-11 20:03 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2022-01-11 15:23 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (3.46 KB, patch)
2022-01-11 16:31 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (3.76 KB, patch)
2022-01-11 16:53 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2022-01-11 15:18:42 PST 
WebPageProxy destruction should not launch a network process
Comment 1 Geoffrey Garen 2022-01-11 15:23:25 PST 
Created attachment 448883 [details]
Patch
Comment 2 Alex Christensen 2022-01-11 16:05:54 PST 
Comment on attachment 448883 [details]
Patch

This is not a bad idea.  It can be tested by extending the NetworkProcess.LaunchOnlyWhenNecessary API test.
Comment 3 Geoffrey Garen 2022-01-11 16:31:45 PST 
Created attachment 448890 [details]
Patch
Comment 4 Alex Christensen 2022-01-11 16:32:52 PST 
Comment on attachment 448890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448890&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:95
> +    webView = nullptr;

Does this destroy the WebPageProxy?  I would expect an @autoreleasepool somewhere to prevent any autoreleased objects from keeping it alive.
Comment 5 Geoffrey Garen 2022-01-11 16:53:12 PST 
Created attachment 448892 [details]
Patch
Comment 6 EWS 2022-01-11 20:02:40 PST 
Committed r287907 (245940@main): <https://commits.webkit.org/245940@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448892 [details].
Comment 7 Radar WebKit Bug Importer 2022-01-11 20:03:16 PST 
<rdar://problem/87433821>