WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
235082
[JSC] Fix kind of error thrown by wasm module creation
https://bugs.webkit.org/show_bug.cgi?id=235082
Summary
[JSC] Fix kind of error thrown by wasm module creation
Yusuke Suzuki
Reported
2022-01-11 14:02:11 PST
[JSC] Fix kind of error thrown by wasm module creation
Attachments
Patch
(1.71 KB, patch)
2022-01-11 14:03 PST
,
Yusuke Suzuki
msaboff
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2022-01-11 14:03:07 PST
Created
attachment 448876
[details]
Patch
Michael Saboff
Comment 2
2022-01-11 14:05:17 PST
Comment on
attachment 448876
[details]
Patch r=me
Yusuke Suzuki
Comment 3
2022-01-11 14:08:21 PST
Comment on
attachment 448876
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=448876&action=review
> Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp:58 > if (UNLIKELY(!error)) {
I'll also remove RETURN_IF_EXCEPTION thing in L49 since this is not necessary. createJSWebAssemblyCompileError will not throw. So, the code should be aligned to L61.
Yusuke Suzuki
Comment 4
2022-01-11 15:41:37 PST
Committed
r287901
(?): <
https://commits.webkit.org/r287901
>
Radar WebKit Bug Importer
Comment 5
2022-01-11 15:42:16 PST
<
rdar://problem/87423396
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug