Bug 235082 - [JSC] Fix kind of error thrown by wasm module creation
Summary: [JSC] Fix kind of error thrown by wasm module creation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-11 14:02 PST by Yusuke Suzuki
Modified: 2022-01-11 15:42 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.71 KB, patch)
2022-01-11 14:03 PST, Yusuke Suzuki
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2022-01-11 14:02:11 PST
[JSC] Fix kind of error thrown by wasm module creation
Comment 1 Yusuke Suzuki 2022-01-11 14:03:07 PST
Created attachment 448876 [details]
Patch
Comment 2 Michael Saboff 2022-01-11 14:05:17 PST
Comment on attachment 448876 [details]
Patch

r=me
Comment 3 Yusuke Suzuki 2022-01-11 14:08:21 PST
Comment on attachment 448876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448876&action=review

> Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp:58
>      if (UNLIKELY(!error)) {

I'll also remove RETURN_IF_EXCEPTION thing in L49 since this is not necessary. createJSWebAssemblyCompileError will not throw.
So, the code should be aligned to L61.
Comment 4 Yusuke Suzuki 2022-01-11 15:41:37 PST
Committed r287901 (?): <https://commits.webkit.org/r287901>
Comment 5 Radar WebKit Bug Importer 2022-01-11 15:42:16 PST
<rdar://problem/87423396>