Bug 235081 - Update hashThreadState() to exclude __opaque_flags.
Summary: Update hashThreadState() to exclude __opaque_flags.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Keywords: InRadar
Depends on: 235156
  Show dependency treegraph
Reported: 2022-01-11 12:53 PST by Mark Lam
Modified: 2022-01-12 16:37 PST (History)
10 users (show)

See Also:

proposed patch. (10.29 KB, patch)
2022-01-11 13:32 PST, Mark Lam
keith_miller: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-01-11 12:53:52 PST
Also remove some unused code.

Comment 1 Mark Lam 2022-01-11 13:32:23 PST
Created attachment 448875 [details]
proposed patch.
Comment 2 Keith Miller 2022-01-11 13:43:20 PST
Comment on attachment 448875 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=448875&action=review

> Source/WTF/wtf/threads/Signals.cpp:175
> +    // Exclude the __opaque_flags field which is reserved for OS use.

Nit: Maybe say that __opaque_flags is at the end of the payload.
Comment 3 Mark Lam 2022-01-11 20:04:41 PST
(In reply to Keith Miller from comment #2)
> Nit: Maybe say that __opaque_flags is at the end of the payload.

Thanks for the review.  I've added the comment.

Landed in r287908: <http://trac.webkit.org/r287908>.
Comment 4 WebKit Commit Bot 2022-01-12 13:52:36 PST
Re-opened since this is blocked by bug 235156
Comment 5 Mark Lam 2022-01-12 16:37:50 PST
Re-landed in r287961: <http://trac.webkit.org/r287961>.