Bug 235060 – [CSS contain] Update css-contain tests from WPT

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Rob Buis]

[CSS contain] Update css-contain tests from WPT

[Rob Buis]

Created attachment 448833 [details]
Patch

[Rob Buis]

Created attachment 448834 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 448834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448834&action=review

> LayoutTests/imported/w3c/ChangeLog:11
> +        This also changes many test expectations to expect PASSes instead of FAILs. Since they
> +        actually fail these need to be skipped for now.

Is this a common practice? I believe we usually prefer to have things with FAIL to detect regressions/progressions on patches.

If we just skip tests, we are going to detect that we improve anything, unless we unskip them.

[Manuel Rego Casasnovas]

Comment on attachment 448834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448834&action=review

> LayoutTests/imported/w3c/ChangeLog:15
> +        * web-platform-tests/css/css-contain/contain-inline-size-bfc-floats-001-expected.html: Added.
> +        * web-platform-tests/css/css-contain/contain-inline-size-bfc-floats-001-ref.html: Added.

These 2 files are duplicated? It seems we have some problem in the import script.

[Rob Buis]

Created attachment 448846 [details]
Patch

[Rob Buis]

Comment on attachment 448834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448834&action=review

>> LayoutTests/imported/w3c/ChangeLog:11
>> +        actually fail these need to be skipped for now.
> 
> Is this a common practice? I believe we usually prefer to have things with FAIL to detect regressions/progressions on patches.
> 
> If we just skip tests, we are going to detect that we improve anything, unless we unskip them.

Not common, I removed it in the new patch.

>> LayoutTests/imported/w3c/ChangeLog:15
>> +        * web-platform-tests/css/css-contain/contain-inline-size-bfc-floats-001-ref.html: Added.
> 
> These 2 files are duplicated? It seems we have some problem in the import script.

Right, this is behaviour since https://bugs.webkit.org/show_bug.cgi?id=234510 landed. On advice of ntim I reverted it locally, so the new patch has no -ref files anymore.

[Manuel Rego Casasnovas]

Comment on attachment 448846 [details]
Patch

r=me, thanks.

[EWS]

Committed r287882 (245926@main): <https://commits.webkit.org/245926@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448846 [details].

[Radar WebKit Bug Importer]

<rdar://problem/87404377>