Bug 235060 - [CSS contain] Update css-contain tests from WPT
Summary: [CSS contain] Update css-contain tests from WPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-11 02:08 PST by Rob Buis
Modified: 2022-01-11 09:45 PST (History)
5 users (show)

See Also:

Attachments
Patch (119.07 KB, patch)
2022-01-11 02:15 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (335.31 KB, patch)
2022-01-11 02:24 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (140.89 KB, patch)
2022-01-11 07:23 PST, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2022-01-11 02:08:05 PST 
[CSS contain] Update css-contain tests from WPT
Comment 1 Rob Buis 2022-01-11 02:15:17 PST 
Created attachment 448833 [details]
Patch
Comment 2 Rob Buis 2022-01-11 02:24:52 PST 
Created attachment 448834 [details]
Patch
Comment 3 Manuel Rego Casasnovas 2022-01-11 03:25:04 PST 
Comment on attachment 448834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448834&action=review

> LayoutTests/imported/w3c/ChangeLog:11
> +        This also changes many test expectations to expect PASSes instead of FAILs. Since they
> +        actually fail these need to be skipped for now.

Is this a common practice? I believe we usually prefer to have things with FAIL to detect regressions/progressions on patches.

If we just skip tests, we are going to detect that we improve anything, unless we unskip them.
Comment 4 Manuel Rego Casasnovas 2022-01-11 03:38:19 PST 
Comment on attachment 448834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448834&action=review

> LayoutTests/imported/w3c/ChangeLog:15
> +        * web-platform-tests/css/css-contain/contain-inline-size-bfc-floats-001-expected.html: Added.
> +        * web-platform-tests/css/css-contain/contain-inline-size-bfc-floats-001-ref.html: Added.

These 2 files are duplicated? It seems we have some problem in the import script.
Comment 5 Rob Buis 2022-01-11 07:23:53 PST 
Created attachment 448846 [details]
Patch
Comment 6 Rob Buis 2022-01-11 07:54:05 PST 
Comment on attachment 448834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448834&action=review

>> LayoutTests/imported/w3c/ChangeLog:11
>> +        actually fail these need to be skipped for now.
> 
> Is this a common practice? I believe we usually prefer to have things with FAIL to detect regressions/progressions on patches.
> 
> If we just skip tests, we are going to detect that we improve anything, unless we unskip them.

Not common, I removed it in the new patch.

>> LayoutTests/imported/w3c/ChangeLog:15
>> +        * web-platform-tests/css/css-contain/contain-inline-size-bfc-floats-001-ref.html: Added.
> 
> These 2 files are duplicated? It seems we have some problem in the import script.

Right, this is behaviour since https://bugs.webkit.org/show_bug.cgi?id=234510 landed. On advice of ntim I reverted it locally, so the new patch has no -ref files anymore.
Comment 7 Manuel Rego Casasnovas 2022-01-11 08:21:41 PST 
Comment on attachment 448846 [details]
Patch

r=me, thanks.
Comment 8 EWS 2022-01-11 09:44:21 PST 
Committed r287882 (245926@main): <https://commits.webkit.org/245926@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448846 [details].
Comment 9 Radar WebKit Bug Importer 2022-01-11 09:45:17 PST 
<rdar://problem/87404377>