Bug 23506 - Upstream chromium's image decoders
Summary: Upstream chromium's image decoders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-23 10:39 PST by Darin Fisher (:fishd, Google)
Modified: 2009-01-26 12:03 PST (History)
0 users

See Also:


Attachments
patch: part 1 - copy existing files (100.24 KB, patch)
2009-01-23 10:41 PST, Darin Fisher (:fishd, Google)
eric: review+
Details | Formatted Diff | Diff
patch: part 2 - copy ImageDecoder.h as well (8.29 KB, patch)
2009-01-23 10:55 PST, Darin Fisher (:fishd, Google)
eric: review+
Details | Formatted Diff | Diff
patch: part 3 - apply skia changes on top (148.90 KB, patch)
2009-01-23 10:59 PST, Darin Fisher (:fishd, Google)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-01-23 10:39:45 PST
Upstream chromium's image decoders

From here:
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/image-decoders/skia/

My plan is to attach two patches.  The first will copy the existing PNG, JPEG, and GIF decoders.  Then, I will do a subsequent change, which applies our changes as well as adds BMP, ICO, and XBM decoders.
Comment 1 Darin Fisher (:fishd, Google) 2009-01-23 10:41:02 PST
Created attachment 26975 [details]
patch: part 1 - copy existing files
Comment 2 Eric Seidel (no email) 2009-01-23 10:43:23 PST
Comment on attachment 26975 [details]
patch: part 1 - copy existing files

rs=me
Comment 3 Darin Fisher (:fishd, Google) 2009-01-23 10:55:56 PST
Created attachment 26976 [details]
patch: part 2 - copy ImageDecoder.h as well
Comment 4 Darin Fisher (:fishd, Google) 2009-01-23 10:59:23 PST
Created attachment 26977 [details]
patch: part 3 - apply skia changes on top
Comment 5 Eric Seidel (no email) 2009-01-23 11:20:03 PST
Comment on attachment 26976 [details]
patch: part 2 - copy ImageDecoder.h as well

rs=me
Comment 6 Eric Seidel (no email) 2009-01-23 11:21:55 PST
Comment on attachment 26977 [details]
patch: part 3 - apply skia changes on top

This is a bit hard to review at this size.  It is possible to split out the adds into a new patch?  Or somehow make this one smaller?
Comment 7 Eric Seidel (no email) 2009-01-23 12:26:31 PST
Comment on attachment 26977 [details]
patch: part 3 - apply skia changes on top

Gonna rubber stamp this.  I've reviewed this already when you submitted it to our local branch.

My understanding of the "grand plan" is that Hyatt was interested in replacing the shared decoders with Chromium's decoders.  Peter Kasting intends to take care of that merging/replacement work.