Bug 235049 – Remove unused Document::ListenerType enumerators

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Alexey Shvayka]

Remove unused Document::ListenerType enumerators

[Alexey Shvayka]

Created attachment 448804 [details]
Patch

[Darin Adler]

Comment on attachment 448804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448804&action=review

> Source/WebCore/ChangeLog:9
> +        Except for RESIZE_LISTENER, which just seems to be left behind, legacyType() of EventTarget.cpp
> +        handles all other event types, deleted in this patch, according to the spec [1].

We could also change this to an OptionSet some day, and STOP USING ALL CAPITAL LETTERS FOR IT. The style being so stream is just because this is really old.

[Darin Adler]

Comment on attachment 448804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448804&action=review

>> Source/WebCore/ChangeLog:9
>> +        handles all other event types, deleted in this patch, according to the spec [1].
> 
> We could also change this to an OptionSet some day, and STOP USING ALL CAPITAL LETTERS FOR IT. The style being so stream is just because this is really old.

strange, not stream, thanks autocorrect (or my brain)

[Darin Adler]

Did I forget to set review+? Oops!

[Radar WebKit Bug Importer]

<rdar://problem/87689367>

[Alexey Shvayka]

Committed r288584 (246406@trunk): <https://commits.webkit.org/246406@trunk>

[Alexey Shvayka]

Thanks Darin and Sam!

(In reply to Darin Adler from comment #2)
> We could also change this to an OptionSet some day, and STOP USING ALL
> CAPITAL LETTERS FOR IT. The style being so stream is just because this is
> really old.

That would be nice, added a FIXME.