Bug 235049 - Remove unused Document::ListenerType enumerators
Summary: Remove unused Document::ListenerType enumerators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Enhancement
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-10 15:09 PST by Alexey Shvayka
Modified: 2022-01-25 14:10 PST (History)
7 users (show)

See Also:


Attachments
Patch (4.41 KB, patch)
2022-01-10 15:13 PST, Alexey Shvayka
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2022-01-10 15:09:13 PST
Remove unused Document::ListenerType enumerators
Comment 1 Alexey Shvayka 2022-01-10 15:13:16 PST
Created attachment 448804 [details]
Patch
Comment 2 Darin Adler 2022-01-10 18:02:32 PST
Comment on attachment 448804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448804&action=review

> Source/WebCore/ChangeLog:9
> +        Except for RESIZE_LISTENER, which just seems to be left behind, legacyType() of EventTarget.cpp
> +        handles all other event types, deleted in this patch, according to the spec [1].

We could also change this to an OptionSet some day, and STOP USING ALL CAPITAL LETTERS FOR IT. The style being so stream is just because this is really old.
Comment 3 Darin Adler 2022-01-10 18:02:55 PST
Comment on attachment 448804 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448804&action=review

>> Source/WebCore/ChangeLog:9
>> +        handles all other event types, deleted in this patch, according to the spec [1].
> 
> We could also change this to an OptionSet some day, and STOP USING ALL CAPITAL LETTERS FOR IT. The style being so stream is just because this is really old.

strange, not stream, thanks autocorrect (or my brain)
Comment 4 Darin Adler 2022-01-11 08:40:38 PST
Did I forget to set review+? Oops!
Comment 5 Radar WebKit Bug Importer 2022-01-17 15:10:18 PST
<rdar://problem/87689367>
Comment 6 Alexey Shvayka 2022-01-25 14:09:15 PST
Committed r288584 (246406@trunk): <https://commits.webkit.org/246406@trunk>
Comment 7 Alexey Shvayka 2022-01-25 14:10:15 PST
Thanks Darin and Sam!

(In reply to Darin Adler from comment #2)
> We could also change this to an OptionSet some day, and STOP USING ALL
> CAPITAL LETTERS FOR IT. The style being so stream is just because this is
> really old.

That would be nice, added a FIXME.