Bug 235041 - Remove AppleTV specific disabling of conic gradients, its not necessary
Summary: Remove AppleTV specific disabling of conic gradients, its not necessary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-10 11:22 PST by Sam Weinig
Modified: 2022-01-11 07:43 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.16 KB, patch)
2022-01-10 11:23 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (4.41 KB, patch)
2022-01-10 17:44 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (4.37 KB, patch)
2022-01-11 06:31 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2022-01-10 11:22:06 PST 
Remove AppleTV specific disabling of conic gradients, its not necessary
Comment 1 Sam Weinig 2022-01-10 11:23:35 PST 
Created attachment 448780 [details]
Patch
Comment 2 Darin Adler 2022-01-10 15:00:33 PST 
Comment on attachment 448780 [details]
Patch

Did I wrote those FIXMEs? Sounds like me.

What about the closely related tvOS exception for ENABLE_CSS_CONIC_GRADIENTS in PlatformEnableCocoa.h? (also ENABLE_MONOSPACE_FONT_EXCEPTION is likely a similar mistake)
Comment 3 Sam Weinig 2022-01-10 17:44:49 PST 
Created attachment 448819 [details]
Patch
Comment 4 Sam Weinig 2022-01-10 17:46:45 PST 
Since the last patch broke windows, this new one keeps the conditional but makes it a HAVE and then bases ENABLE_CSS_CONIC_GRADIENTS on that HAVE. Does this look good to you?
Comment 5 Darin Adler 2022-01-10 18:08:25 PST 
Comment on attachment 448819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448819&action=review

> Source/WTF/wtf/PlatformEnableCocoa.h:182
> +#if !defined(ENABLE_CSS_CONIC_GRADIENTS) && HAVE(CORE_GRAPHICS_CONIC_GRADIENTS)

Since this is a Cocoa-only file, you could omit the HAVE() call here.
Comment 6 Sam Weinig 2022-01-11 06:31:04 PST 
Created attachment 448842 [details]
Patch
Comment 7 EWS 2022-01-11 07:42:24 PST 
Committed r287879 (245923@main): <https://commits.webkit.org/245923@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448842 [details].
Comment 8 Radar WebKit Bug Importer 2022-01-11 07:43:16 PST 
<rdar://problem/87397803>