RESOLVED FIXED Bug 235033
[EWS] Accept GitHub hooks 
https://bugs.webkit.org/show_bug.cgi?id=235033
Summary [EWS] Accept GitHub hooks
Jonathan Bedard
Reported 2022-01-10 09:33:37 PST
ewe-build.webkit.org should accept hooks from GitHub.
Attachments
Patch (6.16 KB, patch)
2022-01-12 09:20 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (6.27 KB, patch)
2022-01-12 09:30 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (8.03 KB, patch)
2022-01-12 11:43 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (8.02 KB, patch)
2022-01-12 12:00 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (7.92 KB, patch)
2022-01-12 13:09 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-01-10 09:33:57 PST
<rdar://problem/87345269>
Jonathan Bedard
Comment 2 2022-01-10 09:39:07 PST
PR: https://github.com/WebKit/WebKit/pull/66
Jonathan Bedard
Comment 3 2022-01-12 09:20:15 PST
Created attachment 448953 [details] Patch
Jonathan Bedard
Comment 4 2022-01-12 09:30:25 PST
Created attachment 448955 [details] Patch
Jonathan Bedard
Comment 5 2022-01-12 11:43:17 PST
Created attachment 448979 [details] Patch
Jonathan Bedard
Comment 6 2022-01-12 12:00:33 PST
Created attachment 448982 [details] Patch
Jonathan Bedard
Comment 7 2022-01-12 13:09:51 PST
Created attachment 448988 [details] Patch
Jonathan Bedard
Comment 8 2022-01-12 13:19:10 PST Comment hidden (obsolete)
Aakash Jain
Comment 9 2022-01-12 15:20:35 PST
Comment on attachment 448988 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448988&action=review > Tools/CISupport/ews-build/master.cfg:57 > admin_username = os.getenv('EWS_ADMIN_USERNAME') would be good to change other os.getenv in this file to load_password as well (in subsequent patch).
Aakash Jain
Comment 10 2022-01-17 14:07:46 PST
(In reply to Aakash Jain from comment #9) > would be good to change other os.getenv in this file to load_password as well (in subsequent patch). Doing this in Bug 235296.
Aakash Jain
Comment 11 2022-01-17 14:09:55 PST
(In reply to Jonathan Bedard from comment #8) > Landed: 245976@main (r287947) Above comment was incorrect. Correct commit id was: https://commits.webkit.org/245978@main (287949)
Note You need to log in before you can comment on or make changes to this bug.