Bug 235033 - [EWS] Accept GitHub hooks
Summary: [EWS] Accept GitHub hooks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-01-10 09:33 PST by Jonathan Bedard
Modified: 2022-01-31 13:26 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.16 KB, patch)
2022-01-12 09:20 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (6.27 KB, patch)
2022-01-12 09:30 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (8.03 KB, patch)
2022-01-12 11:43 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (8.02 KB, patch)
2022-01-12 12:00 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (7.92 KB, patch)
2022-01-12 13:09 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2022-01-10 09:33:37 PST 
ewe-build.webkit.org should accept hooks from GitHub.
Comment 1 Radar WebKit Bug Importer 2022-01-10 09:33:57 PST 
<rdar://problem/87345269>
Comment 2 Jonathan Bedard 2022-01-10 09:39:07 PST 
PR: https://github.com/WebKit/WebKit/pull/66
Comment 3 Jonathan Bedard 2022-01-12 09:20:15 PST 
Created attachment 448953 [details]
Patch
Comment 4 Jonathan Bedard 2022-01-12 09:30:25 PST 
Created attachment 448955 [details]
Patch
Comment 5 Jonathan Bedard 2022-01-12 11:43:17 PST 
Created attachment 448979 [details]
Patch
Comment 6 Jonathan Bedard 2022-01-12 12:00:33 PST 
Created attachment 448982 [details]
Patch
Comment 7 Jonathan Bedard 2022-01-12 13:09:51 PST 
Created attachment 448988 [details]
Patch
Comment 8 Jonathan Bedard 2022-01-12 13:19:10 PST Comment hidden (obsolete)
Comment 9 Aakash Jain 2022-01-12 15:20:35 PST 
Comment on attachment 448988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448988&action=review

> Tools/CISupport/ews-build/master.cfg:57
>      admin_username = os.getenv('EWS_ADMIN_USERNAME')

would be good to change other os.getenv in this file to load_password as well (in subsequent patch).
Comment 10 Aakash Jain 2022-01-17 14:07:46 PST 
(In reply to Aakash Jain from comment #9)
> would be good to change other os.getenv in this file to load_password as well (in subsequent patch).
Doing this in Bug 235296.
Comment 11 Aakash Jain 2022-01-17 14:09:55 PST 
(In reply to Jonathan Bedard from comment #8)
> Landed: 245976@main (r287947)
Above comment was incorrect. Correct commit id was: https://commits.webkit.org/245978@main (287949)